fixes a few issues with out_dtype overload for addmm/baddbmm#167931
Closed
fixes a few issues with out_dtype overload for addmm/baddbmm#167931
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167931
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 146a4d9 with merge base e5eb89e ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/b200
ciflow/h100
ciflow/rocm
ngimel
force-pushed
the
ngimel/addmm_dtype
branch
from
68b0050 to
c64d82e
Compare
ngimel
force-pushed
the
ngimel/addmm_dtype
branch
from
c64d82e to
1ffde37
Compare
nikitaved
reviewed
Nov 17, 2025
PaulZhang12
approved these changes
Nov 17, 2025
Contributor
PaulZhang12
left a comment
PaulZhang12
left a comment
There was a problem hiding this comment.
Thanks for the fixes!
drisspg
reviewed
Nov 17, 2025
drisspg
approved these changes
Nov 17, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
malfet
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per title
selfargument to have the same precision as outputselfargument - it used to allocate incorrectly sized output and resize it later, causing a warning, in addmm, and error out in baddbmmouthandling foroutbaddbmm overload, where the implementation used uninitialized memory inoutinstead of copyingselfto out.cc @PaulZhang12 @nikitaved