control_plane: add handler for WaitCounters#167871
Closed
d4l3k wants to merge 1 commit intopytorch:mainfrom
Closed
control_plane: add handler for WaitCounters#167871d4l3k wants to merge 1 commit intopytorch:mainfrom
d4l3k wants to merge 1 commit intopytorch:mainfrom
Conversation
pytorch-bot
bot
added
oncall: distributed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167871
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a0736b1 with merge base 1c0bf2a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
The label |
pytorch-bot
bot
added
the
oncall: distributed
pytorch-bot
bot
removed
the
oncall: distributed
|
The label |
d4l3k
force-pushed
the
export-D87095718
branch
from
727b507 to
422354f
Compare
d4l3k
added a commit
to d4l3k/pytorch
that referenced
this pull request
Nov 14, 2025
Summary: This adds a DebugServer handler for WaitCounters such that we can access all wait counters live via HTTP. To do so we register a wait counter backend that tracks all counter values in a shared synchronized map. When creating a counter this will acquire the lock to add it to the global map but during runtime it only uses atomic operation. Test Plan: ``` //caffe2/test/distributed/elastic:test_control_plane ``` Differential Revision: D87095718
pytorch-bot
bot
added
oncall: distributed
|
The label |
d4l3k
added a commit
to d4l3k/pytorch
that referenced
this pull request
Nov 14, 2025
Summary: This adds a DebugServer handler for WaitCounters such that we can access all wait counters live via HTTP. To do so we register a wait counter backend that tracks all counter values in a shared synchronized map. When creating a counter this will acquire the lock to add it to the global map but during runtime it only uses atomic operation. Test Plan: ``` //caffe2/test/distributed/elastic:test_control_plane ``` Differential Revision: D87095718
d4l3k
force-pushed
the
export-D87095718
branch
from
422354f to
ea25537
Compare
pytorch-bot
bot
added
oncall: distributed
|
The label |
Skylion007
reviewed
Nov 16, 2025
| data->total_time_us.load(std::memory_order_relaxed); | ||
| counter_obj["max_time_us"] = | ||
| data->max_time_us.load(std::memory_order_relaxed); | ||
| j[name] = counter_obj; |
Collaborator
There was a problem hiding this comment.
I doubt the json object is trivially copyable.
Suggested change
| j[name] = counter_obj; | |
| j[name] = std::move(counter_obj); |
Skylion007
reviewed
Nov 16, 2025
| explicit TrackingBackend(std::string key) : key_(std::move(key)) { | ||
| // Get or create counter data for this key | ||
| getCounterDataMapHolder()->map.withLock([&](auto& map) { | ||
| auto it = map.find(key_); |
Collaborator
There was a problem hiding this comment.
Am wondering if there is a way looking up the key iterator twice in C++17. There is try_emplace but that make_shared_ptr semantics complicates that bit and we don't want to unconditionally create the shared pointer.
This is fine as is though
Summary: This adds a DebugServer handler for WaitCounters such that we can access all wait counters live via HTTP. To do so we register a wait counter backend that tracks all counter values in a shared synchronized map. When creating a counter this will acquire the lock to add it to the global map but during runtime it only uses atomic operation. Test Plan: ``` //caffe2/test/distributed/elastic:test_control_plane ``` Differential Revision: D87095718
d4l3k
force-pushed
the
export-D87095718
branch
from
ea25537 to
a0736b1
Compare
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
Summary: This adds a DebugServer handler for WaitCounters such that we can access all wait counters live via HTTP. To do so we register a wait counter backend that tracks all counter values in a shared synchronized map. When creating a counter this will acquire the lock to add it to the global map but during runtime it only uses atomic operation. Test Plan: ``` //caffe2/test/distributed/elastic:test_control_plane ``` Differential Revision: D87095718 Pull Request resolved: #167871 Approved by: https://github.com/fduwjj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This adds a DebugServer handler for WaitCounters such that we can access all wait counters live via HTTP.
To do so we register a wait counter backend that tracks all counter values in a shared synchronized map. When creating a counter this will acquire the lock to add it to the global map but during runtime it only uses atomic operation.
Test Plan:
Differential Revision: D87095718
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @pragupta @msaroufim @dcci