add assume_32bit_indexing inductor config#167784
Closed
laithsakka wants to merge 3 commits intogh/laithsakka/327/basefrom
Closed
add assume_32bit_indexing inductor config#167784laithsakka wants to merge 3 commits intogh/laithsakka/327/basefrom
laithsakka wants to merge 3 commits intogh/laithsakka/327/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167784
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 2e41407 with merge base 1a67403 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
when we know all tensor and intermediate tesnors fit in 32 bit but used unbacked DS we want a way to allow assumes that (we will runtime assert on it). but its not practical to torch check every possible intermediate tesnors. this is needed to enhance vLLM perf with unbacked. since in vLLM all tensors and intermediates assumed to fit in 32 bits. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela [ghstack-poisoned]
jansel
approved these changes
Nov 14, 2025
when we know all tensor and intermediate tensors fit in 32 bit but use unbacked DS we want a way to assume that we can use 32 bit indexing(we will runtime assert on it). It is not practical to torch check every possible intermediate tensor size ahead of time. This is needed to enhance vLLM perf with unbacked, since in vLLM all tensors and intermediates assumed to fit in 32 bits. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jsuarez5341
pushed a commit
to PufferAI/pytorch
that referenced
this pull request
Nov 15, 2025
when we know all tensor and intermediate tensors fit in 32 bit but use unbacked DS we want a way to assume that we can use 32 bit indexing(we will runtime assert on it). It is not practical to torch check every possible intermediate tensor size ahead of time. This is needed to enhance vLLM perf with unbacked, since in vLLM all tensors and intermediates assumed to fit in 32 bits. Pull Request resolved: pytorch#167784 Approved by: https://github.com/jansel
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
when we know all tensor and intermediate tensors fit in 32 bit but use unbacked DS we want a way to assume that we can use 32 bit indexing(we will runtime assert on it). It is not practical to torch check every possible intermediate tensor size ahead of time. This is needed to enhance vLLM perf with unbacked, since in vLLM all tensors and intermediates assumed to fit in 32 bits. Pull Request resolved: pytorch#167784 Approved by: https://github.com/jansel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
when we know all tensor and intermediate tensors fit in 32 bit but use unbacked DS
we want a way to assume that we can use 32 bit indexing(we will runtime assert on it).
It is not practical to torch check every possible intermediate tensor size ahead of time.
This is needed to enhance vLLM perf with unbacked, since in vLLM all tensors and
intermediates assumed to fit in 32 bits.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela