Skip to content

[3.14, jit] skip jit tests on 3.14+, add jit deprecation warnings to user-facing API#167669

Closed
williamwen42 wants to merge 2 commits intogh/williamwen42/346/basefrom
gh/williamwen42/346/head
Closed

[3.14, jit] skip jit tests on 3.14+, add jit deprecation warnings to user-facing API#167669
williamwen42 wants to merge 2 commits intogh/williamwen42/346/basefrom
gh/williamwen42/346/head

Conversation

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167669

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a94305c with merge base 8919f69 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.


def script_method(fn):
if sys.version_info >= (3, 14):
warnings.warn(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be an error?

torch.jit.save(m, 'scriptmodule.pt', _extra_files=extra_files)
"""
if sys.version_info >= (3, 14):
warnings.warn(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raise RuntimeError

@williamwen42
Copy link
Member Author

Raising an error would require a lot more changes since @torch.jit.* is used in a lot of test files outside of test_jit.*.py - there isn't a good place to catch these errors and skip the tests since they happen at import time when module-level functions are decorated with @torch.jit.*.

…arnings to user-facing API"

cc EikanWang jgong5 wenzhe-nrv sanchitintel gujinghui PenghuiCheng XiaobingSuper jianyuh mingfeima ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #167700

pytorchmergebot pushed a commit that referenced this pull request Nov 14, 2025
Failing test was `pytest test/export/test_export.py -k test_python_asserts_with_sym_int`

Pull Request resolved: #167700
Approved by: https://github.com/bobrenjc93
ghstack dependencies: #167382, #167383, #167384, #167387, #167396, #167669
Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025
Silv3S pushed a commit to Silv3S/pytorch that referenced this pull request Nov 18, 2025
Failing test was `pytest test/export/test_export.py -k test_python_asserts_with_sym_int`

Pull Request resolved: pytorch#167700
Approved by: https://github.com/bobrenjc93
ghstack dependencies: pytorch#167382, pytorch#167383, pytorch#167384, pytorch#167387, pytorch#167396, pytorch#167669
@github-actions github-actions bot deleted the gh/williamwen42/346/head branch December 14, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/linux-aarch64 linux aarch64 CI workflow Merged module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration oncall: jit Add this issue/PR to JIT oncall triage queue release notes: jit release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants