[inductor] layout constraint for weight-norm-bwd#167667
Closed
shunting314 wants to merge 3 commits intogh/shunting314/261/basefrom
Closed
[inductor] layout constraint for weight-norm-bwd#167667shunting314 wants to merge 3 commits intogh/shunting314/261/basefrom
shunting314 wants to merge 3 commits intogh/shunting314/261/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167667
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 1 Pending, 4 Unrelated FailuresAs of commit 804e47a with merge base e8d411e ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
eellison
approved these changes
Nov 12, 2025
fix #165749 The weight_norm backward kernel requires its inputs to be contiguous. Add those constraints to the lowering/fallback rule. A better fix is maybe add decomposition rule for the op. But since we already fallback, this fix does no harm and can fix the attached issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15) Details for Dev Infra teamRaised by workflow job |
fix #165749 The weight_norm backward kernel requires its inputs to be contiguous. Add those constraints to the lowering/fallback rule. A better fix is maybe add decomposition rule for the op. But since we already fallback, this fix does no harm and can fix the attached issue. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jsuarez5341
pushed a commit
to PufferAI/pytorch
that referenced
this pull request
Nov 15, 2025
fix pytorch#165749 The weight_norm backward kernel requires its inputs to be contiguous. Add those constraints to the lowering/fallback rule. A better fix is maybe add decomposition rule for the op. But since we already fallback, this fix does no harm and can fix the attached issue. Pull Request resolved: pytorch#167667 Approved by: https://github.com/eellison
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
fix pytorch#165749 The weight_norm backward kernel requires its inputs to be contiguous. Add those constraints to the lowering/fallback rule. A better fix is maybe add decomposition rule for the op. But since we already fallback, this fix does no harm and can fix the attached issue. Pull Request resolved: pytorch#167667 Approved by: https://github.com/eellison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
fix #165749
The weight_norm backward kernel requires its inputs to be contiguous. Add those constraints to the lowering/fallback rule.
A better fix is maybe add decomposition rule for the op. But since we already fallback, this fix does no harm and can fix the attached issue.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben