[Quant][CPU] fix fp8 qconv#167611
Closed
jiayisunx wants to merge 5 commits intogh/jiayisunx/89/basefrom
Closed
Conversation
jiayisunx
requested review from
digantdesai,
jerryzh168,
jianyuh,
kimishpatel and
salilsdesai
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167611
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 06b23f4 with merge base aa504d4 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: cpu
Xia-Weiwen
approved these changes
Nov 17, 2025
Collaborator
Xia-Weiwen
left a comment
Xia-Weiwen
left a comment
There was a problem hiding this comment.
LGTM. Some minor changes may be needed.
mingfeima
approved these changes
Nov 24, 2025
Collaborator
|
fix CI failures if any. |
Collaborator
Author
|
Hi @jerryzh168 , could you please review this PR? thanks! |
jerryzh168
approved these changes
Nov 26, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
Summary: Fix fp8 qconv to support fp8_input/fp8_weight/bf16_bias in and bf16_output out. Pull Request resolved: #167611 Approved by: https://github.com/Xia-Weiwen, https://github.com/mingfeima, https://github.com/jerryzh168
Xia-Weiwen
pushed a commit
to yanbing-j/pytorch
that referenced
this pull request
Dec 19, 2025
Summary: Fix fp8 qconv to support fp8_input/fp8_weight/bf16_bias in and bf16_output out. Pull Request resolved: pytorch#167611 Approved by: https://github.com/Xia-Weiwen, https://github.com/mingfeima, https://github.com/jerryzh168
yanbing-j
pushed a commit
to yanbing-j/pytorch
that referenced
this pull request
Dec 22, 2025
Summary: Fix fp8 qconv to support fp8_input/fp8_weight/bf16_bias in and bf16_output out. Pull Request resolved: pytorch#167611 Approved by: https://github.com/Xia-Weiwen, https://github.com/mingfeima, https://github.com/jerryzh168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Fix fp8 qconv to support fp8_input/fp8_weight/bf16_bias in and bf16_output out.
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @aditew01