Move CppTypeToScalarType to torch/headeronly#167610
Closed
mikaylagawarecki wants to merge 2 commits intogh/mikaylagawarecki/374/basefrom
Closed
Move CppTypeToScalarType to torch/headeronly#167610mikaylagawarecki wants to merge 2 commits intogh/mikaylagawarecki/374/basefrom
mikaylagawarecki wants to merge 2 commits intogh/mikaylagawarecki/374/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167610
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 7aaa5fa with merge base 3e7a66f ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pearu
approved these changes
Nov 13, 2025
Collaborator
pearu
left a comment
pearu
left a comment
There was a problem hiding this comment.
I have a nit but otherwise LGTM!
[ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: Approvers from one of the following sets are needed:
|
janeyx99
approved these changes
Nov 14, 2025
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jsuarez5341
pushed a commit
to PufferAI/pytorch
that referenced
this pull request
Nov 15, 2025
Pull Request resolved: pytorch#167610 Approved by: https://github.com/pearu, https://github.com/janeyx99
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
Pull Request resolved: pytorch#167610 Approved by: https://github.com/pearu, https://github.com/janeyx99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):