Skip to content

[Inductor][2/2] Decouple flags for optimization and debug symbols#167575

Closed
bbeckca wants to merge 1 commit intopytorch:mainfrom
bbeckca:export-D86683526
Closed

[Inductor][2/2] Decouple flags for optimization and debug symbols#167575
bbeckca wants to merge 1 commit intopytorch:mainfrom
bbeckca:export-D86683526

Conversation

@bbeckca
Copy link
Contributor

@bbeckca bbeckca commented Nov 11, 2025

Summary:
What: Decouple flags for compile (unoptimized build) and symbols (optimized build)
Why: Reduce confusion around naming and usage

Test Plan: Unit test & CI

Differential Revision: D86683526

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167575

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 6b1ff74 with merge base c5d91d9 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-codesync
Copy link

meta-codesync bot commented Nov 11, 2025

@bbeckca has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86683526.

@bbeckca
Copy link
Contributor Author

bbeckca commented Nov 11, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 11, 2025
@bbeckca bbeckca requested review from hl475 and jansel November 11, 2025 20:54
bbeckca added a commit to bbeckca/pytorch that referenced this pull request Nov 11, 2025
…torch#167575)

Summary:

What: Decouple flags for compile (unoptimized build) and symbols (optimized build)
Why: Reduce confusion around naming and usage

Test Plan: Unit test & CI

Differential Revision: D86683526
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 11, 2025
bbeckca added a commit to bbeckca/pytorch that referenced this pull request Nov 11, 2025
…torch#167575)

Summary:

What: Decouple flags for compile (unoptimized build) and symbols (optimized build)
Why: Reduce confusion around naming and usage

Test Plan: Unit test & CI

Differential Revision: D86683526
bbeckca added a commit to bbeckca/pytorch that referenced this pull request Nov 11, 2025
…torch#167575)

Summary:

What: Decouple flags for compile (unoptimized build) and symbols (optimized build)
Why: Reduce confusion around naming and usage

Test Plan: Unit test & CI

Differential Revision: D86683526
@bbeckca bbeckca force-pushed the export-D86683526 branch 2 times, most recently from 38d37b8 to c05f86b Compare November 11, 2025 22:37
bbeckca added a commit to bbeckca/pytorch that referenced this pull request Nov 11, 2025
…torch#167575)

Summary:

What: Decouple flags for compile (unoptimized build) and symbols (optimized build)
Why: Reduce confusion around naming and usage

Test Plan: Unit test & CI

Differential Revision: D86683526
@hl475
Copy link
Contributor

hl475 commented Nov 12, 2025

fix the lint?

bbeckca added a commit to bbeckca/pytorch that referenced this pull request Nov 12, 2025
…torch#167575)

Summary:

What: Decouple flags for compile (unoptimized build) and symbols (optimized build)
Why: Reduce confusion around naming and usage

Test Plan: Unit test & CI

Differential Revision: D86683526
bbeckca added a commit to bbeckca/pytorch that referenced this pull request Nov 12, 2025
…torch#167575)

Summary:

What: Decouple flags for compile (unoptimized build) and symbols (optimized build)
Why: Reduce confusion around naming and usage

Test Plan: Unit test & CI

Differential Revision: D86683526
…torch#167575)

Summary:

What: Decouple flags for compile (unoptimized build) and symbols (optimized build)
Why: Reduce confusion around naming and usage

Test Plan: Unit test & CI

Differential Revision: D86683526
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Silv3S pushed a commit to Silv3S/pytorch that referenced this pull request Nov 18, 2025
…torch#167575)

Summary:
What: Decouple flags for compile (unoptimized build) and symbols (optimized build)
Why: Reduce confusion around naming and usage

Test Plan: Unit test & CI

Differential Revision: D86683526

Pull Request resolved: pytorch#167575
Approved by: https://github.com/jansel, https://github.com/hl475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants