[HOP][print][dynamo]Add dynamo for hop print#167571

Closed

fxdawnn wants to merge 19 commits intogh/fxdawnn/11/basefrom

gh/fxdawnn/11/head

Contributor

fxdawnn commented Nov 11, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

Following the previous implementation of HOP print, this continues to enable HOP print for dynamo so as to enable eager full graph and aot_eager backend for torch compile. At the end of the the implementation, the HOP print is able to enable stateful print without causing graph break. In the prior built in print, dynamo is able to reduce the graph break but unable to eliminate it. This enable the format-based printing for such purpose in dynamo.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela


          [HOP][print][dynamo]Add dynamo for hop print

1317bf6

[ghstack-poisoned]

fxdawnn requested a review from zou3519 as a code owner

November 11, 2025 19:48

fxdawnn mentioned this pull request

[HOP][print] Add functionalization (make sure ordering) for print #167016

Closed

pytorch-bot bot commented Nov 11, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167571

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 4aed0eb with merge base 200156e ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 2, 2, linux.2xlarge.amx) (gh) (trunk failure)
stable_diffusion_unet
inductor / inductor-cpu-test / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.2xlarge.amx) (gh) (trunk failure)
stable_diffusion_unet
inductor / inductor-test / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
stable_diffusion_unet

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge, unstable) (gh) (#166072)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor module: dynamo labels

fxdawnn added a commit that referenced this pull request


          [HOP][print][dynamo]Add dynamo for hop print

8f6dba0

ghstack-source-id: 67a3b59
Pull Request resolved: #167571

fxdawnn requested review from angelayi and anijain2305

November 11, 2025 19:49

fxdawnn added module: printing topic: not user facing labels

fxdawnn self-assigned this


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

f52b28c

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

fxdawnn added a commit that referenced this pull request


          [HOP][print][dynamo]Add dynamo for hop print with 0 graph break testing

8c2605f

ghstack-source-id: 0f076d3
Pull Request resolved: #167571


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

827f943

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

fxdawnn added a commit that referenced this pull request


          [HOP][print][dynamo]Add dynamo handle of error

7bd44ae

ghstack-source-id: 99e2ace
Pull Request resolved: #167571

angelayi reviewed

View reviewed changes

test/higher_order_ops/test_print.py Outdated Show resolved Hide resolved

test/higher_order_ops/test_print.py Outdated Show resolved Hide resolved

test/higher_order_ops/test_print.py Outdated Show resolved Hide resolved

test/higher_order_ops/test_print.py Outdated Show resolved Hide resolved

torch/_dynamo/variables/higher_order_ops.py Outdated Show resolved Hide resolved

torch/_dynamo/variables/higher_order_ops.py Outdated Show resolved Hide resolved


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

8ceb31f

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

fxdawnn added a commit that referenced this pull request


          [HOP][print][dynamo]Fix dynamo calling error

e55dec8

ghstack-source-id: 94ec22d
Pull Request resolved: #167571


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

c23a98d

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

fxdawnn added a commit that referenced this pull request


          [HOP][print][dynamo]Fix dynamo tracing

98b72ab

ghstack-source-id: e32b0e0
Pull Request resolved: #167571


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

655b6f4

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

fxdawnn added a commit that referenced this pull request


          [HOP][print][dynamo]Fix dynamo tracing

fda8c2d

ghstack-source-id: 1d40267
Pull Request resolved: #167571


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

cc0ca81

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

fxdawnn added a commit that referenced this pull request


          [HOP][print][dynamo]Add more test for dynamo full graph aot_eager

3d58b78

ghstack-source-id: e922fb6
Pull Request resolved: #167571

fxdawnn mentioned this pull request

[Inductor][HOP][print]Add inductor and IR class for print #167680

Closed

angelayi reviewed

View reviewed changes

test/higher_order_ops/test_print.py Outdated Show resolved Hide resolved

fxdawnn added 3 commits

November 13, 2025 08:43


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

32f86d8



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

b5e999f



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

9883e0c



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

e2ed8c3



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

fxdawnn added a commit that referenced this pull request


          [HOP][print][dynamo]Remove extensive tests

03b8df7

ghstack-source-id: 232dbab
Pull Request resolved: #167571

angelayi reviewed

View reviewed changes

test/higher_order_ops/test_print.py Outdated Show resolved Hide resolved

test/higher_order_ops/test_print.py Outdated Show resolved Hide resolved

test/higher_order_ops/test_print.py Outdated Show resolved Hide resolved

fxdawnn added 8 commits

November 14, 2025 13:48


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

e6511c1



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

def361d



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

d3b2c4c



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

5ee4f7e



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

d349ee7



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

3dc1847



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

282fdfc



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[HOP][print][dynamo]Add dynamo for hop print"

4aed0eb



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request


          Fix linter

cbca141

ghstack-source-id: ab930f1
Pull Request resolved: pytorch/pytorch#167571

Khanaksahu pushed a commit to Khanaksahu/pytorch-fork that referenced this pull request


          Fix test for the alternative input

077575b

ghstack-source-id: 0d8a29f
Pull Request resolved: pytorch/pytorch#167571

angelayi approved these changes

View reviewed changes

Contributor Author

fxdawnn commented Nov 17, 2025

@pytorchbot merge

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Nov 17, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

2d14e86

pytorchmergebot removed the merging label

github-actions bot deleted the gh/fxdawnn/11/head branch

December 19, 2025 02:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Merged module: dynamo module: printing topic: not user facing