[ROCm] Disable group gemm CK path when composable kernel (CK) is not enabled#167403
[ROCm] Disable group gemm CK path when composable kernel (CK) is not enabled#167403jagadish-amd wants to merge 2 commits intopytorch:mainfrom
Conversation
For ROCm windows, make sure use_fast_path is false so that CK path is not triggered since CK is currently not enabled on windows. Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167403
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 26 Pending, 2 Unrelated FailuresAs of commit 0a6d3c9 with merge base 2325c51 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@ScottTodd Can you please review, it will be great if you can confirm that the ROCm windows build is success with this PR. |
|
@pytorchbot label "topic: not user facing" |
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
I would prefer a revert for obviously broken code over an attempt to fix forward.
Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com>
jagadish-amd
changed the title
|
Build is success with |
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
Looks about right to me, but please revert before attempting to fix forward. We've had broken nightly release builds for 5 days now (https://github.com/ROCm/TheRock/actions/workflows/release_windows_pytorch_wheels.yml?query=branch%3Amain) and it will be at least another 1-2 days before we'll have a chance at clear signal again even if this is reviewed+approved+merged quickly.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -f "rocm only changes, rocm build successful, lint passing" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…enabled (pytorch#167403) For ROCm builds without CK support, ensure use_fast_path is false so that the CK path is not triggered, since CK is currently not available in this configuration. Pull Request resolved: pytorch#167403 Approved by: https://github.com/Skylion007, https://github.com/ScottTodd, https://github.com/jeffdaily
6 participants
For ROCm builds without CK support, ensure use_fast_path is false so that the CK path is not triggered, since CK is currently not available in this configuration.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd