[Inductor] Decouple flags for optimization and debug symbols#167385
Closed
bbeckca wants to merge 1 commit intopytorch:mainfrom
Closed
[Inductor] Decouple flags for optimization and debug symbols#167385bbeckca wants to merge 1 commit intopytorch:mainfrom
bbeckca wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167385
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4eb121b with merge base 69ecb56 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
…#167385) Summary: What: Decouple flags for optimization and debug symbols Why: The current flag for debug symbols only compiles the .so binary in unoptimized mode Test Plan: ``` mkdir -p ~/testing manifold get ads_storage_fblearner/tree/user/facebook/fblearner/predictor/812888234/215/lowering/.predictor.local/input_model ~/testing/812888234_215.input.predictor.local rm -rf /var/tmp/torchinductor_* && buck2 run mode/opt deeplearning/aot_inductor/cpu:cli -- --local-model-path ~/testing/812888234_215.input.predictor.local --submodule mix --preset ads_pre_match_ranking 2>&1 | tee benchmark_test.txt ``` Before: P2028790409 contains "O0", “g” After: P2028736491 contains "O3", "DNDEBUG", “g” ``` mkdir -p ~/testing manifold get ads_storage_fblearner/tree/user/facebook/fblearner/predictor/726554047/202/lowering/.predictor.local/input_model ~/testing/726554047_202.input.predictor.local rm -rf /var/tmp/torchinductor_* && buck2 run mode/opt deeplearning/aot_inductor/cpu:cli -- --local-model-path ~/testing/726554047_202.input.predictor.local --submodule merge --preset ads_second_stage_ranking_type_2 2>&1 | tee benchmark_test.txt ``` Before: P2028790088 contains "O3", "DNDEBUG", After: P2028744377 contains "O3", "DNDEBUG", Differential Revision: D86363355
bbeckca
force-pushed
the
export-D86363355
branch
from
3745c10 to
4eb121b
Compare
hl475
approved these changes
Nov 8, 2025
Contributor
hl475
left a comment
hl475
left a comment
There was a problem hiding this comment.
thanks for decoupling this!
jansel
approved these changes
Nov 8, 2025
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
…#167385) Summary: What: Decouple flags for optimization and debug symbols Why: The current flag for debug symbols only compiles the .so binary in unoptimized mode Differential Revision: D86363355 Pull Request resolved: pytorch#167385 Approved by: https://github.com/hl475, https://github.com/jansel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
What: Decouple flags for optimization and debug symbols
Why: The current flag for debug symbols only compiles the .so binary in unoptimized mode
Differential Revision: D86363355
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben