[dynamo][guards] Fix mem leak in tensor subclass metadata guard#167352
Closed
anijain2305 wants to merge 1 commit intogh/anijain2305/949/basefrom
Closed
[dynamo][guards] Fix mem leak in tensor subclass metadata guard#167352anijain2305 wants to merge 1 commit intogh/anijain2305/949/basefrom
anijain2305 wants to merge 1 commit intogh/anijain2305/949/basefrom
Conversation
Use cls instead of the object. Earlier the metadata guard was holding on to the Dtensor causing mem leak. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167352
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fa78e2e with merge base 2f52235 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
approved these changes
Nov 7, 2025
anijain2305
added
ciflow/trunk
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Thanks! Is there a test that can be added? |
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
…rch#167352) Use cls instead of the object. Earlier the metadata guard was holding on to the Dtensor causing mem leak. Pull Request resolved: pytorch#167352 Approved by: https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Use cls instead of the object. Earlier the metadata guard was holding on
to the Dtensor causing mem leak.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela