[ROCm] Specialized binary elementwise broadcast kernel for mixed dtypes with float/bfloat16/half#167233
Closed
jerrymannil wants to merge 2 commits intopytorch:mainfrom
Closed
[ROCm] Specialized binary elementwise broadcast kernel for mixed dtypes with float/bfloat16/half#167233jerrymannil wants to merge 2 commits intopytorch:mainfrom
jerrymannil wants to merge 2 commits intopytorch:mainfrom
Conversation
… float/bfloat16/half
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167233
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 598d9b3 with merge base 73078f3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
Reproducer: Results (MI300X): |
jeffdaily
approved these changes
Nov 6, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jerrymannil
added a commit
to ROCm/pytorch
that referenced
this pull request
Nov 7, 2025
…es with float/bfloat16/half cherry-pick of pytorch#167233
jerrymannil
added a commit
to ROCm/pytorch
that referenced
this pull request
Nov 7, 2025
…es with float/bfloat16/half (#2791) cherry-pick of pytorch#167233 Fixes #SWDEV-551924
jerrymannil
added a commit
to ROCm/pytorch
that referenced
this pull request
Nov 7, 2025
…es with float/bfloat16/half cherry-pick of pytorch#167233
jerrymannil
added a commit
to ROCm/pytorch
that referenced
this pull request
Nov 7, 2025
…es with float/bfloat16/half (#2795) cherry-pick of pytorch#167233 Fixes #SWDEV-551924
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
…es with float/bfloat16/half (pytorch#167233) * `c10::fetch_and_cast` and `c10::cast_and_store` produce branchy code since it supports all datatypes * So, we do special handling for binary elementwise broadcast with mixed dtypes of float/bfloat16/half * This improves performance Pull Request resolved: pytorch#167233 Approved by: https://github.com/jeffdaily
jerrymannil
added a commit
to ROCm/pytorch
that referenced
this pull request
Nov 19, 2025
…es with float/bfloat16/half cherry-pick of pytorch#167233
jerrymannil
added a commit
to ROCm/pytorch
that referenced
this pull request
Nov 19, 2025
…es with float/bfloat16/half (#2818) cherry-pick of pytorch#167233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c10::fetch_and_castandc10::cast_and_storeproduce branchy code since it supports all datatypescc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd