Skip to content

[MPS] sparse sparse mm#167013

Closed
Isalia20 wants to merge 1 commit intopytorch:mainfrom
Isalia20:mps-sparse-sparse-mm
Closed

[MPS] sparse sparse mm#167013
Isalia20 wants to merge 1 commit intopytorch:mainfrom
Isalia20:mps-sparse-sparse-mm

Conversation

@Isalia20
Copy link
Collaborator

@Isalia20 Isalia20 commented Nov 4, 2025 •
edited by pytorch-bot bot
Loading

Sparse sparse mm op implementation

cc @kulinseth @malfet @DenisVieriu97 @jhavukainen

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167013

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e88d698 with merge base 8fff7e3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Nov 4, 2025
@Isalia20 Isalia20 requested a review from malfet November 4, 2025 21:52
@Isalia20 Isalia20 added topic: improvements topic category module: mps Related to Apple Metal Performance Shaders framework release notes: mps Release notes category labels Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 7, 2025
@Isalia20 Isalia20 requested a review from albanD November 7, 2025 17:16
@Isalia20 Isalia20 added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 8, 2025
@Isalia20 Isalia20 requested a review from Skylion007 November 9, 2025 21:09
@malfet
Copy link
Contributor

malfet commented Nov 10, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 10, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Silv3S pushed a commit to Silv3S/pytorch that referenced this pull request Nov 18, 2025
@Isalia20 @Silv3S
[MPS] sparse sparse mm (pytorch#167013)
2a5e75c 
Sparse sparse mm op implementation

Pull Request resolved: pytorch#167013
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@albanD albanD Awaiting requested review from albanD

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: mps Related to Apple Metal Performance Shaders framework open source release notes: mps Release notes category release notes: sparse release notes category topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Isalia20 @malfet @pytorchmergebot @pytorchbot @janeyx99