Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167004
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cbec338 with merge base 694592a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
dolpm
changed the title
dolpm
force-pushed
the
export-D86168955
branch
from
5ae5ec0 to
ace6c93
Compare
pytorch-bot bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
Summary: Pull Request resolved: #167004 Test Plan: ci Differential Revision: D86168955
malfet
approved these changes
Nov 5, 2025
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
LGTM, provided CI is green (please check bazel failures, Windows one feels false positive)
malfet
added
release notes: cpp
dolpm
force-pushed
the
export-D86168955
branch
from
ace6c93 to
90bed80
Compare
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 5, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
from
90bed80 to
62b1a6e
Compare
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 5, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
from
62b1a6e to
ecdd29b
Compare
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 5, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
from
ecdd29b to
1a9404e
Compare
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 5, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
from
1a9404e to
d5e1939
Compare
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 6, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 6, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
2 times, most recently
from
6f3550c to
1a66314
Compare
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 6, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
from
1a66314 to
07d8b75
Compare
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 6, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
from
07d8b75 to
4622f42
Compare
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 6, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
from
4622f42 to
2e639e8
Compare
pytorch-bot bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
from
2e639e8 to
644d163
Compare
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 7, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
from
644d163 to
2ce5f60
Compare
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 7, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Nov 7, 2025
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
from
2ce5f60 to
51c53bf
Compare
Summary:
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Test Plan: ci
Reviewed By: malfet, ivy-zhou
Differential Revision: D86168955
dolpm
force-pushed
the
export-D86168955
branch
from
51c53bf to
cbec338
Compare
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Differential Revision: D86168955
Pull Request resolved: pytorch#167004
Approved by: https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TORCH_CHECK is non-fatal by design, but TORCH_CHECK_{COND} macros are fatal. this is confusing, and we should limit fatality to the set of debug macros.
Differential Revision: D86168955