Skip to content

[CP][BE][3/N] Add _templated_ring_attention to the backward compatility stub#166991

Closed
fegin wants to merge 2 commits intogh/fegin/332/basefrom
gh/fegin/332/head
Closed

[CP][BE][3/N] Add _templated_ring_attention to the backward compatility stub#166991
fegin wants to merge 2 commits intogh/fegin/332/basefrom
gh/fegin/332/head

Conversation

@fegin
Copy link
Contributor

@fegin fegin commented Nov 4, 2025 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

While _templated_ring_attention is a private API, it is unfortunatelly used by some packages.
Add it to all so that people can still use it.

cc @H-Huang @awgu @wanchaol @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci

@fegin
Update
0357efb 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166991

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9280272 with merge base ad02bd1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Nov 4, 2025
fegin added a commit that referenced this pull request Nov 4, 2025
@fegin
[CP][BE][3/N] Add _templated_ring_attention to the backward compatili…
d2181e2 
…ty stub

While `_templated_ring_attention` is a private API, it is unfortunatelly used by some packages.
Add it to __all__ so that people can still use it.


ghstack-source-id: bcf5916
Pull-Request: #166991
Skylion007
Skylion007 reviewed Nov 4, 2025
View reviewed changes
torch/distributed/tensor/experimental/_attention.py
_enable_context_parallel_dispatcher,
_is_causal_behavior,
_RotateMethod,
_templated_ring_attention,
Copy link
Collaborator

@Skylion007 Skylion007 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wrap these imports with typing_extesions.deprecated at some point...

Copy link
Contributor Author

@fegin fegin Nov 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good suggestion. Will do that.

Copy link
Contributor Author

@fegin fegin Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the comment, I'll add the deprecation message once the final interfaces are decided.

@fegin
Update
9280272 
[ghstack-poisoned]
fegin added a commit that referenced this pull request Nov 4, 2025
@fegin
[CP][BE][3/N] Add _templated_ring_attention to the backward compatili…
4fa62c2 
…ty stub

While `_templated_ring_attention` is a private API, it is unfortunatelly used by some packages.
Add it to __all__ so that people can still use it.

ghstack-source-id: c46d5e6
Pull-Request: #166991
@fegin
Copy link
Contributor Author

fegin commented Nov 5, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 5, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 5, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/fegin/332/head branch December 6, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@XilunWu XilunWu XilunWu approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: context parallel PyTorch Context Parallel oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: context parallel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fegin @pytorchmergebot @Skylion007 @XilunWu