[Pytorch] Enable aarch64 convert autovec only on clang#166739
[Pytorch] Enable aarch64 convert autovec only on clang#166739Nicoshev wants to merge 1 commit intopytorch:mainfrom
Conversation
Summary: We've noted issues with modern GCC versions. Until further investigation is carried, we'll leave the code only enabled on clang Test Plan: CI Differential Revision: D85968395
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166739
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit be3658b with merge base 239e7b5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
module: cpu
|
@pytorchbot label "module: arm" |
pytorch-bot
bot
added
the
module: arm
Nicoshev
added
ciflow/trunk
Nicoshev
added
the
release notes: cpu (aarch64)
Skylion007
left a comment
Skylion007
left a comment
There was a problem hiding this comment.
Darn, not even fixed in latest version?
|
Thanks for the quick response on this.
It might be a different issue to this https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117001 , havn't done any investigation. This say's it is fixed in 13.3.0 Just done a quick test of this PR , looks like the test failures I reported pass. Will confirm again once it's landed. And then we can upgrade jammy to GCC13 and investigate the problem further. |
robert-hardwick
left a comment
robert-hardwick
left a comment
There was a problem hiding this comment.
Looks Good until we can investigate further.
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Many thanks for the immediate fix :) |
Summary: We've noted issues with modern GCC versions. Until further investigation is carried, we'll leave the code only enabled on clang Test Plan: CI Differential Revision: D85968395 Pull Request resolved: #166739 Approved by: https://github.com/mcfi, https://github.com/Skylion007, https://github.com/robert-hardwick
Summary: We've noted issues with modern GCC versions. Until further investigation is carried, we'll leave the code only enabled on clang Test Plan: CI Differential Revision: D85968395 Pull Request resolved: pytorch#166739 Approved by: https://github.com/mcfi, https://github.com/Skylion007, https://github.com/robert-hardwick
…ch#166739)" This reverts commit 8209a05.
…rch#166739)" This reverts commit 4e1469c.
…ch#166739)" This reverts commit 8209a05.
…rch#166739)" This reverts commit 8c1fd4c.
7 participants
Summary: We've noted issues with modern GCC versions. Until further investigation is carried, we'll leave the code only enabled on clang
Test Plan: CI
Differential Revision: D85968395
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @aditew01 @snadampal @milpuz01 @nikhil-arm @fadara01