Skip to content

[MPS] erfinv for sparse mps#166711

Closed
Isalia20 wants to merge 9 commits intopytorch:mainfrom
Isalia20:mps-erfinv-sparse-mps
Closed

[MPS] erfinv for sparse mps#166711
Isalia20 wants to merge 9 commits intopytorch:mainfrom
Isalia20:mps-erfinv-sparse-mps

Conversation

@Isalia20
Copy link
Collaborator

Should be merged after #166708

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166711

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ba0c81f with merge base 406719c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Oct 31, 2025
@Isalia20 Isalia20 added the topic: improvements topic category label Oct 31, 2025
@github-actions
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

@Isalia20 Isalia20 marked this pull request as draft October 31, 2025 13:51
@Isalia20 Isalia20 added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 2, 2025
@Isalia20
Copy link
Collaborator Author

Isalia20 commented Nov 3, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased mps-erfinv-sparse-mps onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout mps-erfinv-sparse-mps && git pull --rebase)

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Nov 3, 2025
@Isalia20 Isalia20 marked this pull request as ready for review November 3, 2025 08:26
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 3, 2025
@Isalia20 Isalia20 requested a review from albanD November 7, 2025 17:15
@Isalia20 Isalia20 changed the title [MPS] erfinv sparse mps [MPS] erfinv/mv for sparse mps Nov 7, 2025
@Isalia20 Isalia20 added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 8, 2025
@Isalia20 Isalia20 requested a review from Skylion007 November 8, 2025 22:53
@Isalia20 Isalia20 changed the title [MPS] erfinv/mv for sparse mps [MPS] erfinv for sparse mps Nov 9, 2025
@malfet
Copy link
Contributor

malfet commented Nov 10, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Silv3S pushed a commit to Silv3S/pytorch that referenced this pull request Nov 18, 2025
@pearu pearu mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants