Skip to content

[MPS] SparseMps mv op#166708

Closed
Isalia20 wants to merge 3 commits intopytorch:mainfrom
Isalia20:mps-mv
Closed

[MPS] SparseMps mv op#166708
Isalia20 wants to merge 3 commits intopytorch:mainfrom
Isalia20:mps-mv

Conversation

@Isalia20
Copy link
Collaborator

@Isalia20 Isalia20 commented Oct 31, 2025

Should be merged after #166561

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166708

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 80107ac with merge base b83a3f6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Oct 31, 2025
@Isalia20 Isalia20 added the topic: improvements topic category label Oct 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@Isalia20 Isalia20 mentioned this pull request Oct 31, 2025
Closed
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 3, 2025
@Isalia20 Isalia20 requested a review from albanD November 7, 2025 17:30
@Isalia20 Isalia20 added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 7, 2025
Skylion007
Skylion007 previously approved these changes Nov 8, 2025
View reviewed changes
@Skylion007
Copy link
Collaborator

Skylion007 commented Nov 8, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 8, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 10, 2025
@Isalia20 @pytorchmergebot
[MPS] erfinv for sparse mps (#166711)
50af6f3 
Should be merged after #166708
Pull Request resolved: #166711
Approved by: https://github.com/Skylion007, https://github.com/malfet
@jeanschmidt
Copy link
Contributor

jeanschmidt commented Nov 12, 2025

@pytorchbot revert -m "breaks internal signals, see D86606212" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Nov 12, 2025
@pytorchmergebot
Revert "[MPS] SparseMps mv op (#166708)"
4f6aae3 
This reverts commit 406719c.

Reverted #166708 on behalf of https://github.com/jeanschmidt due to breaks internal signals, see D86606212 ([comment](#166708 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2025

@Isalia20 your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Nov 12, 2025
@pytorch-bot pytorch-bot bot dismissed Skylion007’s stale review November 12, 2025 16:12

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@malfet
Copy link
Contributor

malfet commented Nov 12, 2025

@pytorch merge -f "Internal revert seems bogus"

@meta-codesync
Copy link

meta-codesync bot commented Nov 12, 2025

@malfet has imported this pull request. If you are a Meta employee, you can view this in D86879969.

@malfet
Copy link
Contributor

malfet commented Nov 12, 2025

@pytorchbot merge -f "Internal revert seems bogus"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2025

This PR (#166708) was merged in a76dd6b but it is still open, likely due to a Github bug, so mergebot is closing it manually. If you think this is a mistake, please feel free to reopen and contact Dev Infra.

v0i0 pushed a commit that referenced this pull request Nov 12, 2025
@Isalia20 @pytorchmergebot
[MPS] SparseMps mv op (#166708)
a76dd6b 
Should be merged after #166561
Pull Request resolved: #166708
Approved by: https://github.com/malfet
Silv3S pushed a commit to Silv3S/pytorch that referenced this pull request Nov 18, 2025
@Isalia20 @Silv3S
[MPS] SparseMps mv op (pytorch#166708)
e3064a9 
Should be merged after pytorch#166561
Pull Request resolved: pytorch#166708
Approved by: https://github.com/Skylion007
Silv3S pushed a commit to Silv3S/pytorch that referenced this pull request Nov 18, 2025
@Isalia20 @Silv3S
[MPS] erfinv for sparse mps (pytorch#166711)
46712dd 
Should be merged after pytorch#166708
Pull Request resolved: pytorch#166711
Approved by: https://github.com/Skylion007, https://github.com/malfet
Silv3S pushed a commit to Silv3S/pytorch that referenced this pull request Nov 18, 2025
@pytorchmergebot @Silv3S
Revert "[MPS] SparseMps mv op (pytorch#166708)"
6a28cd0 
This reverts commit 406719c.

Reverted pytorch#166708 on behalf of https://github.com/jeanschmidt due to breaks internal signals, see D86606212 ([comment](pytorch#166708 (comment)))
Silv3S pushed a commit to Silv3S/pytorch that referenced this pull request Nov 18, 2025
@Isalia20 @Silv3S
[MPS] SparseMps mv op (pytorch#166708)
134a8ea 
Should be merged after pytorch#166561
Pull Request resolved: pytorch#166708
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@Skylion007 Skylion007 Skylion007 left review comments

@kulinseth kulinseth Awaiting requested review from kulinseth

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category Reverted topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Isalia20 @Skylion007 @pytorchmergebot @jeanschmidt @malfet @pytorchbot @mikaylagawarecki