Skip to content

Revise deprecation warning for ONNX exporter#166692

Closed
justinchuby wants to merge 2 commits intomainfrom
justinchuby/onnx-deprecation-msg
Closed

Revise deprecation warning for ONNX exporter#166692
justinchuby wants to merge 2 commits intomainfrom
justinchuby/onnx-deprecation-msg

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Oct 31, 2025 •
edited by pytorch-bot bot
Loading

Updated deprecation warning for ONNX export to reflect the current state.

cc @titaiwangms

@justinchuby
Revise deprecation warning for ONNX exporter
0c9af83 
Updated deprecation warning for ONNX export.
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Oct 31, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166692

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 173317e with merge base e3ae059 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@justinchuby justinchuby added module: onnx Related to torch.onnx topic: improvements topic category and removed release notes: onnx torch.onnx related changes that should show up in the release notes labels Oct 31, 2025
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Oct 31, 2025
@justinchuby justinchuby requested review from Copilot and titaiwangms and removed request for titaiwangms October 31, 2025 03:30
justinchuby
justinchuby commented Oct 31, 2025
View reviewed changes
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the deprecation warning message for the legacy TorchScript-based ONNX export to reflect that the new torch.export-based ONNX exporter has already become the default (as of PyTorch 2.9).

Key changes:

  • Updated warning text to use past tense ("has become" instead of "will be")
  • Removed instructions for switching to the new exporter since it's now the default
  • Updated documentation URL to point to the correct location
Comments suppressed due to low confidence (1)

torch/onnx/init.py:1

  • The URL path contains a duplicate 'docs' segment (/docs/stable/ instead of /stable/). The correct URL should be https://pytorch.org/docs/stable/onnx_export.html (remove the first 'docs').
# mypy: allow-untyped-defs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jcaip jcaip added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 31, 2025
@justinchuby
Copy link
Collaborator Author

justinchuby commented Oct 31, 2025

@pytorchbot merge -f "lint error unrelated to this change"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BoyuanFeng pushed a commit that referenced this pull request Oct 31, 2025
@justinchuby @BoyuanFeng
Revise deprecation warning for ONNX exporter (#166692)
f31fa21 
Updated deprecation warning for ONNX export to reflect the current state.

Pull Request resolved: #166692
Approved by: https://github.com/titaiwangms
etaf pushed a commit to etaf/pytorch-inductor-xpu that referenced this pull request Nov 4, 2025
@justinchuby @etaf
Revise deprecation warning for ONNX exporter (pytorch#166692)
62f5bd9 
Updated deprecation warning for ONNX export to reflect the current state.

Pull Request resolved: pytorch#166692
Approved by: https://github.com/titaiwangms
@github-actions github-actions bot deleted the justinchuby/onnx-deprecation-msg branch December 1, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@titaiwangms titaiwangms titaiwangms approved these changes

Assignees

@titaiwangms titaiwangms

Labels

Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinchuby @pytorchmergebot @titaiwangms @jcaip @pytorchbot