Skip to content

[MPS] Move logaddexp/logaddexp2 to Metal and support complex#166670

Closed
kurtamohler wants to merge 1 commit intogh/kurtamohler/59/basefrom
gh/kurtamohler/59/head
Closed

[MPS] Move logaddexp/logaddexp2 to Metal and support complex#166670
kurtamohler wants to merge 1 commit intogh/kurtamohler/59/basefrom
gh/kurtamohler/59/head

Conversation

@kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented Oct 30, 2025

Stack from ghstack (oldest at bottom):

NOTE: Complex inputs are only supported in logaddexp. Since logaddexp2 does not support complex inputs for CPU, it is not enabled for MPS in this PR either.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166670

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b35cde7 with merge base b9bcb37 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kurtamohler added a commit that referenced this pull request Oct 30, 2025
@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Oct 30, 2025
@github-actions
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

@malfet
Copy link
Contributor

malfet commented Oct 31, 2025

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BoyuanFeng pushed a commit that referenced this pull request Oct 31, 2025
NOTE: Complex inputs are only supported in `logaddexp`. Since `logaddexp2` does not support complex inputs for CPU, it is not enabled for MPS in this PR either.
Pull Request resolved: #166670
Approved by: https://github.com/malfet
etaf pushed a commit to etaf/pytorch-inductor-xpu that referenced this pull request Nov 4, 2025
…ch#166670)

NOTE: Complex inputs are only supported in `logaddexp`. Since `logaddexp2` does not support complex inputs for CPU, it is not enabled for MPS in this PR either.
Pull Request resolved: pytorch#166670
Approved by: https://github.com/malfet
@github-actions github-actions bot deleted the gh/kurtamohler/59/head branch December 1, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants