[dynamo] support tracing new typing union syntax X | Y#166599
Closed
williamwen42 wants to merge 4 commits intogh/williamwen42/324/basefrom
Closed
[dynamo] support tracing new typing union syntax X | Y#166599williamwen42 wants to merge 4 commits intogh/williamwen42/324/basefrom
williamwen42 wants to merge 4 commits intogh/williamwen42/324/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166599
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit e73c27b with merge base ba71e9c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
SherlockNoMad
approved these changes
Oct 30, 2025
Contributor
|
feel free to remove the test case added in #166443 |
anijain2305
approved these changes
Oct 30, 2025
To do in a followup - I think there's an approach to reconstruct typing variables. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
To do in a followup - I think there's an approach to reconstruct typing variables. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
pytorch-bot
bot
added
the
oncall: distributed
Member
Author
|
@SherlockNoMad updated the test you added - can you review that? |
Contributor
|
All good. You can merge it now. |
Member
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
BoyuanFeng
pushed a commit
that referenced
this pull request
Oct 31, 2025
To do in a followup - I think there's an approach to reconstruct typing variables. Pull Request resolved: #166599 Approved by: https://github.com/SherlockNoMad, https://github.com/anijain2305, https://github.com/Skylion007
etaf
pushed a commit
to etaf/pytorch-inductor-xpu
that referenced
this pull request
Nov 4, 2025
To do in a followup - I think there's an approach to reconstruct typing variables. Pull Request resolved: pytorch#166599 Approved by: https://github.com/SherlockNoMad, https://github.com/anijain2305, https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
To do in a followup - I think there's an approach to reconstruct typing variables.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela