Skip to content

[ROCm] Disable __builtin_amdgcn_rcpf for gfx90a#166454

Closed
pragupta wants to merge 1 commit intopytorch:mainfrom
pragupta:pg-fix-grad-norm
Closed

[ROCm] Disable __builtin_amdgcn_rcpf for gfx90a#166454
pragupta wants to merge 1 commit intopytorch:mainfrom
pragupta:pg-fix-grad-norm

Conversation

@pragupta
Copy link
Collaborator

@pragupta pragupta commented Oct 28, 2025 •
edited by jeffdaily
Loading

Improves accuracy for some failing tests.

test/distributed/composable/fsdp/test_fully_shard_clip_grad_norm.py::TestClipGradNormWorldSize4::test_clip_grad_norm_2d GH job link HUD commit link

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166454

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5739829 with merge base 75f798e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch release notes: cuda release notes category labels Oct 28, 2025
@jeffdaily jeffdaily added release notes: rocm mandatorylabel ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300/MI325 labels Oct 28, 2025
@pragupta
Copy link
Collaborator Author

pragupta commented Oct 29, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 29, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 29, 2025

Successfully rebased pg-fix-grad-norm onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout pg-fix-grad-norm && git pull --rebase)

@pytorch-bot pytorch-bot bot removed ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300/MI325 labels Oct 29, 2025
@jeffdaily jeffdaily added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300/MI325 and removed release notes: cuda release notes category labels Oct 29, 2025
@pruthvistony
Copy link
Collaborator

pruthvistony commented Oct 29, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 29, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 29, 2025

Successfully rebased pg-fix-grad-norm onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout pg-fix-grad-norm && git pull --rebase)

@pytorch-bot pytorch-bot bot removed ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300/MI325 labels Oct 29, 2025
@jeffdaily jeffdaily added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300/MI325 labels Oct 29, 2025
@jithunnair-amd jithunnair-amd added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 29, 2025
@jithunnair-amd
Copy link
Collaborator

jithunnair-amd commented Oct 30, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 30, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 30, 2025

Successfully rebased pg-fix-grad-norm onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout pg-fix-grad-norm && git pull --rebase)

@pytorch-bot pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300/MI325 labels Oct 30, 2025
@jithunnair-amd jithunnair-amd added the ciflow/periodic-rocm-mi200 Trigger "distributed" config CI on ROCm MI200 label Oct 30, 2025
@jithunnair-amd
Copy link
Collaborator

jithunnair-amd commented Oct 30, 2025

@pytorchbot rebase --onto main

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: --onto main

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@jithunnair-amd
Copy link
Collaborator

jithunnair-amd commented Oct 30, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 30, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 30, 2025

Successfully rebased pg-fix-grad-norm onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout pg-fix-grad-norm && git pull --rebase)

@pytorch-bot pytorch-bot bot removed the ciflow/periodic-rocm-mi200 Trigger "distributed" config CI on ROCm MI200 label Oct 30, 2025
@jithunnair-amd jithunnair-amd added the ciflow/periodic-rocm-mi200 Trigger "distributed" config CI on ROCm MI200 label Oct 30, 2025
@pytorch-bot pytorch-bot bot added the ciflow/rocm Trigger "default" config CI on ROCm label Oct 30, 2025
@jeffdaily jeffdaily marked this pull request as ready for review October 30, 2025 21:38
@jeffdaily
Copy link
Collaborator

jeffdaily commented Oct 30, 2025

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2025

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@jeffdaily
Copy link
Collaborator

jeffdaily commented Oct 30, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 30, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 30, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BoyuanFeng pushed a commit that referenced this pull request Oct 31, 2025
@pragupta @BoyuanFeng
[ROCm] Disable __builtin_amdgcn_rcpf for gfx90a (#166454)
3653d14 
Improves accuracy for some failing tests.

test/distributed/_composable/fsdp/test_fully_shard_clip_grad_norm_.py::TestClipGradNormWorldSize4::test_clip_grad_norm_2d [GH job link](https://github.com/pytorch/pytorch/actions/runs/18930221123/job/54046876467) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/f20bf778746a7662a9bdbd2fa49d326772ca90ed)

Pull Request resolved: #166454
Approved by: https://github.com/jerrymannil, https://github.com/jeffdaily
etaf pushed a commit to etaf/pytorch-inductor-xpu that referenced this pull request Nov 4, 2025
@pragupta @etaf
[ROCm] Disable __builtin_amdgcn_rcpf for gfx90a (pytorch#166454)
ac565c8 
Improves accuracy for some failing tests.

test/distributed/_composable/fsdp/test_fully_shard_clip_grad_norm_.py::TestClipGradNormWorldSize4::test_clip_grad_norm_2d [GH job link](https://github.com/pytorch/pytorch/actions/runs/18930221123/job/54046876467) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/f20bf778746a7662a9bdbd2fa49d326772ca90ed)

Pull Request resolved: pytorch#166454
Approved by: https://github.com/jerrymannil, https://github.com/jeffdaily
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

@jerrymannil jerrymannil jerrymannil approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@Aidyn-A Aidyn-A Awaiting requested review from Aidyn-A Aidyn-A is a code owner

Assignees

No one assigned

Labels

ciflow/periodic-rocm-mi200 Trigger "distributed" config CI on ROCm MI200 ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source release notes: rocm mandatorylabel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pragupta @pytorchmergebot @pruthvistony @jithunnair-amd @jeffdaily @jerrymannil @pytorchbot