Avoid creating Python OpSchema in the DTensor dispatch fast path#166372
Closed
swolchok wants to merge 17 commits intogh/swolchok/864/basefrom
Closed
Avoid creating Python OpSchema in the DTensor dispatch fast path#166372swolchok wants to merge 17 commits intogh/swolchok/864/basefrom
swolchok wants to merge 17 commits intogh/swolchok/864/basefrom
Conversation
All we need to do is move a few checks around. [ghstack-poisoned]
This was referenced Oct 7, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166372
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d44b6cf with merge base 780e325 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
oncall: distributed
This was referenced Oct 28, 2025
…sor dispatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…ing Python OpSchema in the DTensor dispatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…e DTensor dispatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…t path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…spatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…atch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…t path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…n OpSchema in the DTensor dispatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
… dispatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…r dispatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…ma in the DTensor dispatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…t path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…in the DTensor dispatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
ezyang
approved these changes
Nov 12, 2025
…comments on "Avoid creating Python OpSchema in the DTensor dispatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…ensor on "Avoid creating Python OpSchema in the DTensor dispatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…n OpSchema in the DTensor dispatch fast path" All we need to do is move a few checks around. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #167475 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 13, 2025
Pull Request resolved: #166808 Approved by: https://github.com/ezyang ghstack dependencies: #167051, #166372
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
All we need to do is move a few checks around. ghstack-source-id: 106864a Pull Request resolved: pytorch/pytorch#166372
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
…orch#166372) All we need to do is move a few checks around. Pull Request resolved: pytorch#166372 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#167051
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
Pull Request resolved: pytorch#166808 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#167051, pytorch#166372
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
…hecks (pytorch#167475) This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. Pull Request resolved: pytorch#167475 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#167051, pytorch#166372, pytorch#166808
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 21, 2025
``` git revert --no-commit 567dcdb 200156e 3d801a4 2034ca9 480b4ff f570e58 ``` And Revert "[DTensor] Document fast-path dispatch (#168192)" And Revert "[DTensor] Fix deadlock after fast cache clear (#168069)" Reverts: * #167860 * #167588 * #167475 * #166808 * #166372 * #168192 * #168069 Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #168264 Approved by: https://github.com/seemethere, https://github.com/malfet
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
``` git revert --no-commit 567dcdb 200156e 3d801a4 2034ca9 480b4ff f570e58 ``` And Revert "[DTensor] Document fast-path dispatch (#168192)" And Revert "[DTensor] Fix deadlock after fast cache clear (#168069)" Reverts: * #167860 * #167588 * #167475 * #166808 * #166372 * #168192 * #168069 Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #168264 Approved by: https://github.com/seemethere, https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
DTensor.__torch_dispatch__#167051All we need to do is move a few checks around.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci