[FlexFlash] Wire up mask_mod + blockmask to flash impl#166359
Closed
drisspg wants to merge 9 commits intogh/drisspg/215/basefrom
Closed
[FlexFlash] Wire up mask_mod + blockmask to flash impl#166359drisspg wants to merge 9 commits intogh/drisspg/215/basefrom
drisspg wants to merge 9 commits intogh/drisspg/215/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166359
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 697f415 with merge base 687c15c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
added
module: cuda
drisspg
commented
Oct 28, 2025
drisspg
commented
Oct 28, 2025
drisspg
commented
Oct 28, 2025
drisspg
commented
Oct 28, 2025
drisspg
added
module: cuda
This was referenced Oct 30, 2025
v0i0
approved these changes
Oct 30, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
BoyuanFeng
pushed a commit
that referenced
this pull request
Oct 31, 2025
I have some local changes that I need to push to flash first Dao-AILab/flash-attention#1970 Pull Request resolved: #166359 Approved by: https://github.com/v0i0
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 1, 2025
…ate space (#166657) Benchmarks on Hopper: Note the triton impl is not using max-autotune because I didnt feel like waiting for 90x plots <img width="12517" height="5995" alt="combined_comparison" src="https://github.com/user-attachments/assets/d94debd9-920d-4413-b51f-b8e906e4fb01" /> Pull Request resolved: #166657 Approved by: https://github.com/v0i0, https://github.com/mlazos, https://github.com/eellison ghstack dependencies: #166359
etaf
pushed a commit
to etaf/pytorch-inductor-xpu
that referenced
this pull request
Nov 4, 2025
I have some local changes that I need to push to flash first Dao-AILab/flash-attention#1970 Pull Request resolved: pytorch#166359 Approved by: https://github.com/v0i0
etaf
pushed a commit
to etaf/pytorch-inductor-xpu
that referenced
this pull request
Nov 4, 2025
…ate space (pytorch#166657) Benchmarks on Hopper: Note the triton impl is not using max-autotune because I didnt feel like waiting for 90x plots <img width="12517" height="5995" alt="combined_comparison" src="https://github.com/user-attachments/assets/d94debd9-920d-4413-b51f-b8e906e4fb01" /> Pull Request resolved: pytorch#166657 Approved by: https://github.com/v0i0, https://github.com/mlazos, https://github.com/eellison ghstack dependencies: pytorch#166359
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
ghstack-source-id: e938aa3 Pull-Request: pytorch/pytorch#166359
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
ghstack-source-id: e938aa3 Pull-Request: pytorch/pytorch#166359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I have some local changes that I need to push to flash first
Dao-AILab/flash-attention#1970
cc @ptrblck @msaroufim @eqy @jerryzh168 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @mlazos @Chillee @yanboliang @BoyuanFeng