[dynamo] Dont guard on numpy Cython functions#166328
[dynamo] Dont guard on numpy Cython functions#166328anijain2305 wants to merge 1 commit intogh/anijain2305/934/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166328
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 71e8531 with merge base 6ecd6b2 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
anijain2305
added
ciflow/trunk
Lucaskabela
left a comment
Lucaskabela
left a comment
There was a problem hiding this comment.
Can we add unit test checking this (only because I worry in the future someone may try and fold these conditionals together with an and, which may be wrong here so we should be sure to have some signal covering)
Other than that lgtm so approving
I am going to add a assertion in CLOSURE_MATCH at the end. Just that I have to send many small PRs before that assertion does not fail. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Pull Request resolved: #166328 Approved by: https://github.com/Lucaskabela
ghstack-source-id: 32bf0c8 Pull Request resolved: pytorch/pytorch#166328
3 participants
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela