[dynamo][guards] Get rid of FUNCTION_MATCH#166321
Open
anijain2305 wants to merge 14 commits intogh/anijain2305/932/basefrom
Open
[dynamo][guards] Get rid of FUNCTION_MATCH#166321anijain2305 wants to merge 14 commits intogh/anijain2305/932/basefrom
anijain2305 wants to merge 14 commits intogh/anijain2305/932/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166321
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 3 Unrelated FailuresAs of commit 60f2d28 with merge base 6c7cad6 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
This was referenced Oct 27, 2025
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Oct 28, 2025
In the previous PRs, we have gotten rid of all FUNCTION_MATCH, but I am hesitant to entirely remove the ID_MATCH because it can cause a failure in the wild. So, replacing with UNCLASSIFIED_ID_MATCH. This will show up in the recompiles reasons in the tlparse if we overguard, and therefore will be easier to track. ghstack-source-id: 1909ddc Pull Request resolved: #166321
anijain2305
changed the title
anijain2305
added
ciflow/trunk
williamwen42
approved these changes
Oct 29, 2025
jansel
approved these changes
Oct 30, 2025
mlazos
approved these changes
Nov 2, 2025
zou3519
approved these changes
Nov 2, 2025
In the previous PRs, we have gotten rid of all FUNCTION_MATCH, but I am
hesitant to entirely remove the ID_MATCH because it can cause a failure
in the wild. So, replacing with UNCLASSIFIED_ID_MATCH. This will show up
in the recompiles reasons in the tlparse if we overguard, and therefore
will be easier to track.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela
[ghstack-poisoned]
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
In the previous PRs, we have gotten rid of all FUNCTION_MATCH, but I am hesitant to entirely remove the ID_MATCH because it can cause a failure in the wild. So, replacing with UNCLASSIFIED_ID_MATCH. This will show up in the recompiles reasons in the tlparse if we overguard, and therefore will be easier to track. ghstack-source-id: b61a78f Pull Request resolved: pytorch/pytorch#166321
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
cyyever
approved these changes
Jan 2, 2026
Collaborator
|
@pytorchmergebot merge -r |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Collaborator
|
Rebase failed due to Command Raised by https://github.com/pytorch/pytorch/actions/runs/20650011528 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
In the previous PRs, we have gotten rid of all FUNCTION_MATCH, but I am
hesitant to entirely remove the ID_MATCH because it can cause a failure
in the wild. So, replacing with UNCLASSIFIED_ID_MATCH. This will show up
in the recompiles reasons in the tlparse if we overguard, and therefore
will be easier to track.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo @chenyang78