[ONNX] Cover all FX passes into backed size oblivious#166151
[ONNX] Cover all FX passes into backed size oblivious#166151titaiwangms wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166151
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 542035e with merge base 5a4997d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
justinchuby
left a comment
There was a problem hiding this comment.
Thanks! Could you add a reference in the PR description?
Updated a repro |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
| # Reassign the graph module to save some runtime. | ||
| exported_program._graph_module = graph_module | ||
| return exported_program | ||
| with ( |
There was a problem hiding this comment.
Should we add the example you found as a unit test?
There was a problem hiding this comment.
I will submit a follow-up
Follow-up #166151 Pull Request resolved: #166196 Approved by: https://github.com/justinchuby
Found a bug that after
run_decomposition(), the shape could be fixed to 1. It's caused by the fact that all FX graph (related to shape inference) surgery should happen inside backed size oblivious patch.