Re-re-re-re-apply "C++-accessible Placements via pybind11 (#163030)"#166132
Re-re-re-re-apply "C++-accessible Placements via pybind11 (#163030)"#166132swolchok wants to merge 2 commits intogh/swolchok/857/basefrom
Conversation
Was reverted (again!) due to a merge conflict that crept in sometime during the "export to github -> land internally -> merge on github" process. Differential Revision: [D85096233](https://our.internmc.facebook.com/intern/diff/D85096233/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166132
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 20a7830 with merge base f89a7e9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: dynamo
oncall: distributed
Was reverted (again!) due to a merge conflict that crept in sometime during the "export to github -> land internally -> merge on github" process. Differential Revision: [D85096233](https://our.internmc.facebook.com/intern/diff/D85096233/) ghstack-source-id: 318252481 Pull Request resolved: #166132
swolchok
added
suppress-bc-linter
|
|
||
| explicit Partial(std::optional<std::string> reduce_op_) | ||
| : reduce_op( | ||
| reduce_op_.has_value() ? std::move(*reduce_op_) |
There was a problem hiding this comment.
Better to use std::optional.value_or?
There was a problem hiding this comment.
probably behaves exactly the same, but certainly reads nicer. normally I would change it but because this PR is getting continually reverted I would prefer to push all further changes to further PRs.
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
…163030)"" Was reverted (again!) due to a merge conflict that crept in sometime during the "export to github -> land internally -> merge on github" process. Differential Revision: [D85096233](https://our.internmc.facebook.com/intern/diff/D85096233/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
Pull Request resolved: #166132 Was reverted (again!) due to a merge conflict that crept in sometime during the "export to github -> land internally -> merge on github" process. ghstack-source-id: 318928038 @exported-using-ghexport Differential Revision: [D85096233](https://our.internmc.facebook.com/intern/diff/D85096233/)
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge failedReason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR! Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f 'internal check is lying' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…166132) Was reverted (again!) due to a merge conflict that crept in sometime during the "export to github -> land internally -> merge on github" process. D85096233 Pull Request resolved: #166132 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet
7 participants
Stack from ghstack (oldest at bottom):
Was reverted (again!) due to a merge conflict that crept in sometime during the "export to github -> land internally -> merge on github" process.
D85096233
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela