[inductor] turn Inductor deterministic mode on with torch.use_deterministic_algorithms#165950
Closed
shunting314 wants to merge 3 commits intogh/shunting314/240/basefrom
Closed
[inductor] turn Inductor deterministic mode on with torch.use_deterministic_algorithms#165950shunting314 wants to merge 3 commits intogh/shunting314/240/basefrom
shunting314 wants to merge 3 commits intogh/shunting314/240/basefrom
Conversation
…nistic_algorithms [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165950
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1da006e with merge base e20c9bf ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…use_deterministic_algorithms" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
v0i0
approved these changes
Oct 22, 2025
eellison
approved these changes
Oct 22, 2025
…use_deterministic_algorithms" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
shunting314
commented
Oct 22, 2025
Comment on lines
-2453
to
-2456
| if config.deterministic: | ||
| torch.backends.cudnn.deterministic = True | ||
| torch.backends.cudnn.benchmark = False | ||
| torch.backends.mkldnn.deterministic = True # type: ignore[assignment] |
Contributor
Author
There was a problem hiding this comment.
Remove these since other tests calling torch.use_deterministic_algorithms(True) will fail due to these flags being frozen.
Expect them to be set outside of torch.compile.
drisspg
reviewed
Oct 22, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
meta-codesync bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Oct 23, 2025
…rithms (#165950) Summary: X-link: pytorch/pytorch#165950 Approved by: https://github.com/v0i0, https://github.com/eellison Reviewed By: clee2000 Differential Revision: D85309471 fbshipit-source-id: 2ff0822293bd65e3ba7ae3d1198496cad42f25f0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela