Skip to content

torch.cond supports autograd now#165908

Closed
ezyang wants to merge 2 commits intogh/ezyang/3177/basefrom
gh/ezyang/3177/head
Closed

torch.cond supports autograd now#165908
ezyang wants to merge 2 commits intogh/ezyang/3177/basefrom
gh/ezyang/3177/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 20, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Signed-off-by: Edward Yang ezyang@meta.com

@ezyang
Update
f5ae035 
[ghstack-poisoned]
@ezyang ezyang requested a review from zou3519 as a code owner October 20, 2025 15:27
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165908

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 3ee7644 with merge base fee1ac9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Oct 20, 2025
@ezyang
torch.cond supports autograd now
bbb3cdb 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 4f51109
Pull-Request: #165908
@ezyang ezyang added release notes: fx release notes category topic: docs topic category labels Oct 20, 2025
@bobrenjc93
Copy link
Contributor

bobrenjc93 commented Oct 20, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 20, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 20, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 20, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@albanD albanD removed their request for review October 20, 2025 21:36
@ezyang
Update
3ee7644 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Nov 3, 2025
@ezyang
torch.cond supports autograd now
98b9564 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 369a290
Pull-Request: #165908
@ezyang
Copy link
Contributor Author

ezyang commented Nov 3, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 3, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Nov 4, 2025
@ezyang @etaf
torch.cond supports autograd now (#165908)
e86ca22 
Signed-off-by: Edward Yang <ezyang@meta.com>
Pull Request resolved: #165908
Approved by: https://github.com/zou3519, https://github.com/ydwu4, https://github.com/Skylion007
@github-actions github-actions bot deleted the gh/ezyang/3177/head branch December 4, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@zou3519 zou3519 zou3519 approved these changes

@ydwu4 ydwu4 ydwu4 approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category topic: docs topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ezyang @bobrenjc93 @pytorchmergebot @Skylion007 @zou3519 @ydwu4