Skip to content

[rfc] add debug mode to print meta in fx graphs#165874

Closed
bobrenjc93 wants to merge 6 commits intogh/bobrenjc93/660/basefrom
gh/bobrenjc93/660/head
Closed

[rfc] add debug mode to print meta in fx graphs#165874
bobrenjc93 wants to merge 6 commits intogh/bobrenjc93/660/basefrom
gh/bobrenjc93/660/head

Conversation

@bobrenjc93
Copy link
Contributor

@bobrenjc93 bobrenjc93 commented Oct 19, 2025

Stack from ghstack (oldest at bottom):

quite useful in debugging things like unbacked bindings (and presumably other mechanisms that dependent on meta including activation checkpointing and stack trace printing)

CleanShot 2025-10-21 at 09 41 54@2x

cc @ezyang @EikanWang @jgong5 @wenzhe-nrv

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165874

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c8203c1 with merge base ba93d56 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Oct 19, 2025
bobrenjc93 added a commit that referenced this pull request Oct 19, 2025
ghstack-source-id: 48e5628
Pull Request resolved: #165874
quite useful in debugging things like unbacked bindings (and presumably other mechanisms that dependent on meta including activation checkpointing and stack trace printing)

<img width="3058" height="1124" alt="CleanShot 2025-10-20 at 00 15 222x" src="https://github.com/user-attachments/assets/fedf3da8-7e0f-4310-8fa0-12d772b0f539" />


cc ezyang EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Oct 20, 2025
ghstack-source-id: aa41cd8
Pull Request resolved: #165874
@bobrenjc93 bobrenjc93 requested a review from ezyang October 20, 2025 07:46
quite useful in debugging things like unbacked bindings (and presumably other mechanisms that dependent on meta including activation checkpointing and stack trace printing)

<img width="3058" height="1124" alt="CleanShot 2025-10-20 at 00 15 222x" src="https://github.com/user-attachments/assets/fedf3da8-7e0f-4310-8fa0-12d772b0f539" />


cc ezyang EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Oct 20, 2025
ghstack-source-id: f092bd3
Pull Request resolved: #165874
@bobrenjc93 bobrenjc93 marked this pull request as ready for review October 20, 2025 23:14
@ezyang
Copy link
Contributor

ezyang commented Oct 21, 2025

Don't you want to format it at least a little more nicely?

@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Oct 21, 2025

@ezyang does this updated rendering logic look good to you?

CleanShot 2025-10-21 at 09 41 54@2x

quite useful in debugging things like unbacked bindings (and presumably other mechanisms that dependent on meta including activation checkpointing and stack trace printing)

<img width="3996" height="748" alt="CleanShot 2025-10-21 at 09 41 542x" src="https://github.com/user-attachments/assets/8b885a36-54a5-48b4-a23c-80b39ac7eb12" />



cc ezyang EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Oct 21, 2025
ghstack-source-id: 608c5b5
Pull Request resolved: #165874
quite useful in debugging things like unbacked bindings (and presumably other mechanisms that dependent on meta including activation checkpointing and stack trace printing)

<img width="3996" height="748" alt="CleanShot 2025-10-21 at 09 41 542x" src="https://github.com/user-attachments/assets/8b885a36-54a5-48b4-a23c-80b39ac7eb12" />



cc ezyang EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Oct 21, 2025
ghstack-source-id: 001b43f
Pull Request resolved: #165874
quite useful in debugging things like unbacked bindings (and presumably other mechanisms that dependent on meta including activation checkpointing and stack trace printing)

<img width="3996" height="748" alt="CleanShot 2025-10-21 at 09 41 542x" src="https://github.com/user-attachments/assets/8b885a36-54a5-48b4-a23c-80b39ac7eb12" />



cc ezyang EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Oct 22, 2025
ghstack-source-id: db4923a
Pull Request resolved: #165874
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suuuure why not

@bobrenjc93
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 27, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

tianrengao pushed a commit that referenced this pull request Oct 30, 2025
quite useful in debugging things like unbacked bindings (and presumably other mechanisms that dependent on meta including activation checkpointing and stack trace printing)

<img width="3996" height="748" alt="CleanShot 2025-10-21 at 09 41 54@2x" src="https://github.com/user-attachments/assets/8b885a36-54a5-48b4-a23c-80b39ac7eb12" />

Pull Request resolved: #165874
Approved by: https://github.com/ezyang
ghstack dependencies: #165893
@github-actions github-actions bot deleted the gh/bobrenjc93/660/head branch November 28, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request fx Merged release notes: fx release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants