Skip to content

Save GitHub env variables on ROCm#165821

Closed
huydhn wants to merge 2 commits intomainfrom
save_github_env_rocm
Closed

Save GitHub env variables on ROCm#165821
huydhn wants to merge 2 commits intomainfrom
save_github_env_rocm

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Oct 18, 2025

As .github/actions/setup-rocm/action.yml is now used on linux_job_v2 to setup ROCm, we need to have this step here to save the list of GitHub env variables.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @akashveramd

Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn requested a review from jithunnair-amd October 18, 2025 04:52
@huydhn huydhn requested a review from a team as a code owner October 18, 2025 04:52
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165821

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit c59833a with merge base 1a34ff4 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Oct 18, 2025
@huydhn
Copy link
Contributor Author

huydhn commented Oct 23, 2025

@pytorchbot merge -f 'CI is ok, the lint failure is bogus'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

huydhn added a commit to pytorch/test-infra that referenced this pull request Oct 23, 2025
Together with pytorch/pytorch#165821, this is to
unblock pytorch/pytorch#165821 because ROCm
runner can't create `artifacts-to-be-uploaded` directory on its
`GITHUB_WORKSPACE` dir

cc @jithunnair-amd @akashveramd

---------

Signed-off-by: Huy Do <huydhn@gmail.com>
huydhn added a commit to pytorch/test-infra that referenced this pull request Oct 28, 2025
Same as pytorch/pytorch#165821, but for non-ROCm
jobs. There are some `test_linux_jobs` that are obsoleted, and don't
work anymore. I can clean them up in another PR. We are all on
`linux_job_v2` now.

I also need to update the test workflow to get rid of `3.9` and `cu121`.

---------

Signed-off-by: Huy Do <huydhn@gmail.com>
@github-actions github-actions bot deleted the save_github_env_rocm branch November 23, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm Trigger "default" config CI on ROCm Merged module: rocm AMD GPU support for Pytorch test-config/default topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants