[ONNX] Create fake implementations for onnx ops; fix boolean mask in attention#165780
Closed
justinchuby wants to merge 13 commits intopytorch:mainfrom
Closed
[ONNX] Create fake implementations for onnx ops; fix boolean mask in attention#165780justinchuby wants to merge 13 commits intopytorch:mainfrom
justinchuby wants to merge 13 commits intopytorch:mainfrom
Conversation
pytorch-bot
bot
added
the
release notes: onnx
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165780
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9fba564 with merge base b31bad1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
cc @jambayk |
justinchuby
added
module: onnx
albanD
added
the
triaged
Collaborator
Author
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Collaborator
|
Successfully rebased |
pytorchmergebot
force-pushed
the
justinchu/meta-native
branch
from
c88c97e to
22a148c
Compare
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
added
topic: bug fixes
justinchuby
changed the title
justinchuby
commented
Oct 28, 2025
xadupre
reviewed
Oct 28, 2025
titaiwangms
reviewed
Oct 28, 2025
titaiwangms
approved these changes
Oct 29, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
BoyuanFeng
pushed a commit
that referenced
this pull request
Oct 31, 2025
…attention (#165780) Previously we rely on the concreate implementation to generate fake implementation. This makes the fake implementation overly complicated and breaks in some cases when there are dynamic shapes. This PR updates onnx op registration to instead take a dedicated fake implementation. **Also fixed: When boolean mask is supplied to torch sdpa, it was previously taken the negation, which is incorrect.** Fix #164909 Also taken changes from #156635 Pull Request resolved: #165780 Approved by: https://github.com/titaiwangms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we rely on the concreate implementation to generate fake implementation. This makes the fake implementation overly complicated and breaks in some cases when there are dynamic shapes.
This PR updates onnx op registration to instead take a dedicated fake implementation.
Also fixed: When boolean mask is supplied to torch sdpa, it was previously taken the negation, which is incorrect.
Fix #164909 Also taken changes from #156635
cc @titaiwangms