[ONNX] Support renaming in dynamic axes to shapes conversion#165769
Closed
titaiwangms wants to merge 4 commits intopytorch:mainfrom
Closed
[ONNX] Support renaming in dynamic axes to shapes conversion#165769titaiwangms wants to merge 4 commits intopytorch:mainfrom
titaiwangms wants to merge 4 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165769
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 683ff64 with merge base faff826 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
justinchuby
reviewed
Oct 17, 2025
justinchuby
approved these changes
Oct 17, 2025
justinchuby
reviewed
Oct 17, 2025
Comment on lines
45
to
46
| "This function converts 'dynamic_axes' format (including custom axis names) to 'dynamic_shapes' format. " | ||
| "Instead of relying on this conversion, provide 'dynamic_shapes' directly using torch.export.Dim objects with custom names.", |
Collaborator
There was a problem hiding this comment.
We do support strings right? Maybe just say supply dynamic_shapes?
Collaborator
Author
There was a problem hiding this comment.
Removed "torch.export.Dim objects"
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…#165769) Discovered in #pytorch#165748 This PR also deprecates the conversion. ONNX exporter team does not intend to maintain the conversion in long term. Pull Request resolved: pytorch#165769 Approved by: https://github.com/justinchuby
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
…#165769) Discovered in #pytorch#165748 This PR also deprecates the conversion. ONNX exporter team does not intend to maintain the conversion in long term. Pull Request resolved: pytorch#165769 Approved by: https://github.com/justinchuby
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered in ##165748
This PR also deprecates the conversion. ONNX exporter team does not intend to maintain the conversion in long term.