Skip to content

[CI] Add rocm CI back to trunk for pre-submit/PR jobs#165674

Closed
jithunnair-amd wants to merge 3 commits intopytorch:mainfrom
ROCm:add_rocm_back_to_trunk
Closed

[CI] Add rocm CI back to trunk for pre-submit/PR jobs#165674
jithunnair-amd wants to merge 3 commits intopytorch:mainfrom
ROCm:add_rocm_back_to_trunk

Conversation

@jithunnair-amd
Copy link
Collaborator

@jithunnair-amd jithunnair-amd commented Oct 16, 2025

Only adding single-GPU shards for now, to observe how current capacity handles it.

cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165674

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 4fbdae2 with merge base d4a713c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Oct 16, 2025
@jithunnair-amd jithunnair-amd changed the title Add rocm CI back to trunk for pre-submit/PR jobs [CI] Add rocm CI back to trunk for pre-submit/PR jobs Oct 16, 2025
@jithunnair-amd jithunnair-amd added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 16, 2025
@jithunnair-amd jithunnair-amd marked this pull request as ready for review October 20, 2025 12:05
@jithunnair-amd jithunnair-amd requested a review from a team as a code owner October 20, 2025 12:05
@jithunnair-amd
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jithunnair-amd jithunnair-amd deleted the add_rocm_back_to_trunk branch October 20, 2025 12:29
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
Only adding single-GPU shards for now, to observe how current capacity handles it.

Pull Request resolved: pytorch#165674
Approved by: https://github.com/jeffdaily
zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Oct 22, 2025
Only adding single-GPU shards for now, to observe how current capacity handles it.

Pull Request resolved: pytorch#165674
Approved by: https://github.com/jeffdaily
malfet added a commit that referenced this pull request Jan 27, 2026
They way they were added by #165674 makes signal from this jobs only visible on PR, but skipped when actually pushed to trunk, see https://hud.pytorch.org/hud/pytorch/pytorch/main/1?per_page=50&name_filter=trunk%20%2F%20linux-jammy-rocm which avoids usual latency monitoring, but creates a very confusing pattern, when `broken on trunk` status is never applied to those jobs

This deficiency was highlighted in late Nov 2025, but still not fix as of late Jan 2026 as of almost


ghstack-source-id: 537d31b
Pull-Request: #173573
pytorchmergebot pushed a commit that referenced this pull request Jan 27, 2026
They way they were added by #165674 makes signal from this jobs only visible on PR, but skipped when actually pushed to trunk, see https://hud.pytorch.org/hud/pytorch/pytorch/main/1?per_page=50&name_filter=trunk%20%2F%20linux-jammy-rocm which avoids usual latency monitoring, but creates a very confusing pattern, when `broken on trunk` status is never applied to those jobs

This deficiency was highlighted in late Nov 2025, but still not fix as of late Jan 2026 as of almost

Pull Request resolved: #173573
Approved by: https://github.com/seemethere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants