[ROCm][Windows] Enable AOTriton runtime compile on Windows#165538
Closed
tvukovic-amd wants to merge 1 commit intopytorch:mainfrom
Closed
[ROCm][Windows] Enable AOTriton runtime compile on Windows#165538tvukovic-amd wants to merge 1 commit intopytorch:mainfrom
tvukovic-amd wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165538
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 88ffbdf with merge base 0c14f55 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
@pytorchbot label "release notes: rocm" |
Contributor
|
@pytorchbot label "module: rocm" |
Contributor
|
@pytorchbot label "module: windows" |
Contributor
|
cc @xinyazhang |
xinyazhang
approved these changes
Oct 15, 2025
tvukovic-amd
force-pushed
the
build_aotriton_runtime_on_windows
branch
from
ad75f32 to
88ffbdf
Compare
jeffdaily
approved these changes
Oct 16, 2025
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
tvukovic-amd
added a commit
to ROCm/pytorch
that referenced
this pull request
Oct 17, 2025
…65538) AOTriton uses prebuilt runtime binaries if the user's ROCm version matches the ones used to generate the prebuilt runtime. However, since there's no prebuilt runtime available for Windows, this check needs to be bypassed for Windows. This PR enables it by changing condition to always build AOTriton runtime from source on Windows. Pull Request resolved: pytorch#165538 Approved by: https://github.com/xinyazhang, https://github.com/jeffdaily
This was referenced Oct 17, 2025
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…65538) AOTriton uses prebuilt runtime binaries if the user's ROCm version matches the ones used to generate the prebuilt runtime. However, since there's no prebuilt runtime available for Windows, this check needs to be bypassed for Windows. This PR enables it by changing condition to always build AOTriton runtime from source on Windows. Pull Request resolved: pytorch#165538 Approved by: https://github.com/xinyazhang, https://github.com/jeffdaily
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
…65538) AOTriton uses prebuilt runtime binaries if the user's ROCm version matches the ones used to generate the prebuilt runtime. However, since there's no prebuilt runtime available for Windows, this check needs to be bypassed for Windows. This PR enables it by changing condition to always build AOTriton runtime from source on Windows. Pull Request resolved: pytorch#165538 Approved by: https://github.com/xinyazhang, https://github.com/jeffdaily
tvukovic-amd
added a commit
to ROCm/pytorch
that referenced
this pull request
Dec 23, 2025
…65538) AOTriton uses prebuilt runtime binaries if the user's ROCm version matches the ones used to generate the prebuilt runtime. However, since there's no prebuilt runtime available for Windows, this check needs to be bypassed for Windows. This PR enables it by changing condition to always build AOTriton runtime from source on Windows. Pull Request resolved: pytorch#165538 Approved by: https://github.com/xinyazhang, https://github.com/jeffdaily
jeffdaily
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Dec 23, 2025
…65538) (#2726) This PR is applied cherry-pick commit from merged [PR](pytorch#165538). Since there's no prebuilt aotriton runtime available for Windows we need to apply this PR to always build aotriton runtime on Windows case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AOTriton uses prebuilt runtime binaries if the user's ROCm version matches the ones used to generate the prebuilt runtime. However, since there's no prebuilt runtime available for Windows, this check needs to be bypassed for Windows. This PR enables it by changing condition to always build AOTriton runtime from source on Windows.
cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd