[PP] Fix edge case with FSDP when stages_per_rank > 3#165467
Closed
H-Huang wants to merge 1 commit intopytorch:mainfrom
Closed
[PP] Fix edge case with FSDP when stages_per_rank > 3#165467H-Huang wants to merge 1 commit intopytorch:mainfrom
H-Huang wants to merge 1 commit intopytorch:mainfrom
Conversation
pytorch-bot
bot
added
the
oncall: distributed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165467
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7ab04e4 with merge base 3a110c9 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
H-Huang
added
release notes: distributed (pipeline)
Member
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 15, 2025
There is an edge case with FSDP + PP when we add UNSHARD + RESHARD, we at max have 3 stages unsharded, https://github.com/pytorch/pytorch/blob/3f83e8915e86a93da2fe01fda45602dcd0e3ebfd/torch/distributed/pipelining/schedules.py#L1029-L1031 This change is need to be able to unshard and reshard a stage multiple times. Pull Request resolved: pytorch#165467 Approved by: https://github.com/wwwjn
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
There is an edge case with FSDP + PP when we add UNSHARD + RESHARD, we at max have 3 stages unsharded, https://github.com/pytorch/pytorch/blob/3f83e8915e86a93da2fe01fda45602dcd0e3ebfd/torch/distributed/pipelining/schedules.py#L1029-L1031 This change is need to be able to unshard and reshard a stage multiple times. Pull Request resolved: pytorch#165467 Approved by: https://github.com/wwwjn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an edge case with FSDP + PP when we add UNSHARD + RESHARD, we at max have 3 stages unsharded,
pytorch/torch/distributed/pipelining/schedules.py
Lines 1029 to 1031 in 3f83e89
This change is need to be able to unshard and reshard a stage multiple times.
cc @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci