Skip to content

[8/N] Apply ruff UP035 rule #165214

Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:ruff035
Closed

[8/N] Apply ruff UP035 rule #165214
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:ruff035

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 11, 2025 •
edited
Loading

This is follow-up of #164653 to continue applying UP035 fixes. The purpose is to finally enable this rule.

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci @ezyang @EikanWang @jgong5 @wenzhe-nrv

@cyyever
Apply ruff UP035 rule
5c6cff2 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165214

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 5c6cff2 with merge base de8d812 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft October 11, 2025 03:53
@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: fx release notes category labels Oct 11, 2025
@cyyever cyyever added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 11, 2025
@cyyever cyyever changed the title Apply ruff UP035 rule [8/N] Apply ruff UP035 rule Oct 11, 2025
@cyyever cyyever marked this pull request as ready for review October 11, 2025 09:14
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 13, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 15, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 15, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 15, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 15, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 15, 2025

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever mentioned this pull request Oct 15, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 17, 2025
@cyyever @pytorchmergebot
[9/N] Apply ruff UP035 rule (#165515)
b2953f5 
This is follow-up of #165214 to continue applying ruff UP035 rule to the code base.

Pull Request resolved: #165515
Approved by: https://github.com/Lucaskabela
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@cyyever @Chao1Han
[8/N] Apply ruff UP035 rule (pytorch#165214)
f4d590e 
This is follow-up of pytorch#164653 to continue applying `UP035` fixes. The purpose is to finally enable this rule.

Pull Request resolved: pytorch#165214
Approved by: https://github.com/ezyang
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@cyyever @Chao1Han
[9/N] Apply ruff UP035 rule (pytorch#165515)
a856cff 
This is follow-up of pytorch#165214 to continue applying ruff UP035 rule to the code base.

Pull Request resolved: pytorch#165515
Approved by: https://github.com/Lucaskabela
zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Oct 22, 2025
@cyyever @zhudada0120
[9/N] Apply ruff UP035 rule (pytorch#165515)
2fab4b1 
This is follow-up of pytorch#165214 to continue applying ruff UP035 rule to the code base.

Pull Request resolved: pytorch#165515
Approved by: https://github.com/Lucaskabela
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@bobrenjc93 bobrenjc93 Awaiting requested review from bobrenjc93 bobrenjc93 is a code owner

@laithsakka laithsakka Awaiting requested review from laithsakka laithsakka is a code owner

@zou3519 zou3519 Awaiting requested review from zou3519 zou3519 is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fx Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: fx release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cyyever @pytorchmergebot @ezyang @facebook-github-bot @soulitzer @pytorchbot