[lint] workflow consistency linter to look at all files instead of just changed files #165171
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165171
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9b07e85 with merge base 0977cc4 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
clee2000
force-pushed
the
csl/workflow_consistency_linter
branch
from
58701be to
a47fc9a
Compare
|
@pytorchbot merge -f "Lint passed" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "broke lint GH job link HUD commit link" -c nosignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
…ad of just changed files (#165171)" This reverts commit c746feb. Reverted #165171 on behalf of https://github.com/clee2000 due to broke lint [GH job link](https://github.com/pytorch/pytorch/actions/runs/18723760085/job/53402955955) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/c746feb86a1459db5f6294730d1d72ed15f16dd3) ([comment](#165171 (comment)))
|
@clee2000 your PR has been successfully reverted. |
clee2000
force-pushed
the
csl/workflow_consistency_linter
branch
from
a38dbdc to
9b07e85
Compare
|
@pytorchbot merge -f "Lint passed" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
As in title
If you change only one workflow file, lintrunner (default arg, also the one in CI since it only inputs changed files) won't look at other files in the repo, but the sync-tag might come from those other files
This makes it so that it looks at all workflow files so it will catch those failures
Also change output line so it prints which file + which job it is different from
Pros:
catches errors
Cons:
unusual behavior (getting around what lintrunner says the linter should run on)