Skip to content

Fix channels-last dimension mapping in CUDA parallel_cat#165023

Closed
ngimel wants to merge 1 commit intomainfrom
codex/refactor-dimension-handling-in-shape.cu
Closed

Fix channels-last dimension mapping in CUDA parallel_cat#165023
ngimel wants to merge 1 commit intomainfrom
codex/refactor-dimension-handling-in-shape.cu

Conversation

@ngimel
Copy link
Collaborator

@ngimel ngimel commented Oct 9, 2025 •
edited
Loading

Fixes #164849
dimension was updated in-place, so for more than one batch of channels-last tensors the concat dimension for the second kernel launch was wrong

Testing

  • python -m compileall test/test_tensor_creation_ops.py

https://chatgpt.com/codex/tasks/task_e_68e708879b30832f89b10ae55faa68e8

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165023

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit 161e164 with merge base 87eccf1 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ngimel ngimel added release notes: cuda release notes category topic: bug fixes topic category labels Oct 9, 2025
ezyang
ezyang approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified all usages of dimension were updated

@ngimel ngimel added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 9, 2025
@ngimel
Copy link
Collaborator Author

ngimel commented Oct 9, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ngimel
Copy link
Collaborator Author

ngimel commented Oct 9, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ngimel
Copy link
Collaborator Author

ngimel commented Oct 9, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2025

Tried to rebase and push PR #165023, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@ngimel
Copy link
Collaborator Author

ngimel commented Oct 9, 2025

@pytorchbot rebase -b main

@ngimel
Copy link
Collaborator Author

ngimel commented Oct 9, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2025

Successfully rebased codex/refactor-dimension-handling-in-shape.cu onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout codex/refactor-dimension-handling-in-shape.cu && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the codex/refactor-dimension-handling-in-shape.cu branch from b76fea5 to 161e164 Compare October 9, 2025 17:33
@ngimel
Copy link
Collaborator Author

ngimel commented Oct 9, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 9, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@ngimel @Chao1Han
Fix channels-last dimension mapping in CUDA parallel_cat (pytorch#165023
573080d 
)

Fixes pytorch#164849
`dimension` was updated in-place, so for more than one batch of channels-last tensors the concat `dimension` for the second kernel launch was wrong

## Testing
- python -m compileall test/test_tensor_creation_ops.py

------
https://chatgpt.com/codex/tasks/task_e_68e708879b30832f89b10ae55faa68e8
Pull Request resolved: pytorch#165023
Approved by: https://github.com/ezyang
@github-actions github-actions bot deleted the codex/refactor-dimension-handling-in-shape.cu branch November 9, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@Aidyn-A Aidyn-A Awaiting requested review from Aidyn-A Aidyn-A is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request codex Merged release notes: cuda release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.stack fails with CUDA error: an illegal memory access was encountered after a permute

3 participants

@ngimel @pytorchmergebot @ezyang