Skip to content

[MPS] sparse norm#164961

Closed
Isalia20 wants to merge 1 commit intopytorch:mainfrom
Isalia20:sparse-norm-mps
Closed

[MPS] sparse norm#164961
Isalia20 wants to merge 1 commit intopytorch:mainfrom
Isalia20:sparse-norm-mps

Conversation

@Isalia20
Copy link
Collaborator

@Isalia20 Isalia20 commented Oct 8, 2025 •
edited by pytorch-bot bot
Loading

Norms for sparse mps tensors

cc @kulinseth @malfet @DenisVieriu97 @jhavukainen

@Isalia20 Isalia20 requested a review from mruberry as a code owner October 8, 2025 18:17
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164961

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0b54130 with merge base c855f86 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Isalia20 Isalia20 added module: mps Related to Apple Metal Performance Shaders framework topic: improvements topic category ciflow/trunk Trigger trunk jobs on your pull request labels Oct 8, 2025
@Isalia20 Isalia20 requested a review from malfet October 8, 2025 18:18
@Isalia20 Isalia20 added the release notes: mps Release notes category label Oct 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@malfet
Copy link
Contributor

malfet commented Oct 8, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 8, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@Isalia20 @Chao1Han
[MPS] sparse norm (pytorch#164961)
b3739ba 
Norms for sparse mps tensors

Pull Request resolved: pytorch#164961
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: mps Related to Apple Metal Performance Shaders framework open source release notes: mps Release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Isalia20 @malfet @pytorchmergebot @pytorchbot