Move from/to to torch::stable::detail#164956
Closed
janeyx99 wants to merge 2 commits intogh/janeyx99/312/basefrom
Closed
Move from/to to torch::stable::detail#164956janeyx99 wants to merge 2 commits intogh/janeyx99/312/basefrom
janeyx99 wants to merge 2 commits intogh/janeyx99/312/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164956
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 5 PendingAs of commit 59ca068 with merge base ab82456 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
janeyx99
added
release notes: cpp
malfet
approved these changes
Oct 20, 2025
| AtenTensorHandle ath = torch::aot_inductor::new_tensor_handle( | ||
| std::move(const_cast<at::Tensor&>(ivalue.toTensor()))); | ||
| return from(ath); | ||
| return torch::stable::detail::from(ath); |
Contributor
There was a problem hiding this comment.
Just add using namespace torch::stable::detail on line 1411 and don't make any changes later on
Contributor
Author
There was a problem hiding this comment.
If we want to keep the global from/to for BC, this leads to ambiguity. I wrote it in my PR desc:
Note that this means that within libtorch, we do not get the luxury of tacking on a using torch::stable::detail::from because then it leads to build time ambiguous calls --> both the global and namespace APIs are exposed, which one do I want? So that is why you see every local site is updated.
| from(std::nullopt), | ||
| from(std::nullopt), | ||
| from(std::nullopt)}; | ||
| torch::stable::detail::from(self), |
Contributor
There was a problem hiding this comment.
Same as above, add using namespace torch::stable::detail
Collaborator
|
Rebased |
Collaborator
|
Starting merge as part of PR stack under #164959 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 21, 2025
Pull Request resolved: #164959 Approved by: https://github.com/Skylion007, https://github.com/mikaylagawarecki ghstack dependencies: #164882, #164956
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
To not pollute the global namespace, we should move the `from`/`to` APIs into torch::stable::detail. We are also following our normal deprecation cycle and choosing to continue exposing the global `from`/`to` for the time being as people who onboard their extensions onto 2.9 would not be able to build with 2.10 otherwise. Note that this means that within libtorch, we do not get the luxury of tacking on a `using torch::stable::detail::from` because then it leads to build time ambiguous calls --> both the global and namespace APIs are exposed, which one do I want? So that is why you see every local site is updated. Note that the update is _not_ necessary from a custom op writer point of view. FA3 can continue to build on torch nightlies without changing any code. (Since this is a header change, this PR has no implication on runtime, a previously built FA3 ABI stable wheel will continue to work fine with newer torch versions after this PR.) Once TORCH_BOX lands, we would be free to remove these global APIs when the deprecation cycle is up (April 2026) and encourage people to use TORCH_BOX and avoid from/to entirely. Pull Request resolved: pytorch#164956 Approved by: https://github.com/malfet ghstack dependencies: pytorch#164882
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
Pull Request resolved: pytorch#164959 Approved by: https://github.com/Skylion007, https://github.com/mikaylagawarecki ghstack dependencies: pytorch#164882, pytorch#164956
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
To not pollute the global namespace, we should move the `from`/`to` APIs into torch::stable::detail. We are also following our normal deprecation cycle and choosing to continue exposing the global `from`/`to` for the time being as people who onboard their extensions onto 2.9 would not be able to build with 2.10 otherwise. Note that this means that within libtorch, we do not get the luxury of tacking on a `using torch::stable::detail::from` because then it leads to build time ambiguous calls --> both the global and namespace APIs are exposed, which one do I want? So that is why you see every local site is updated. Note that the update is _not_ necessary from a custom op writer point of view. FA3 can continue to build on torch nightlies without changing any code. (Since this is a header change, this PR has no implication on runtime, a previously built FA3 ABI stable wheel will continue to work fine with newer torch versions after this PR.) Once TORCH_BOX lands, we would be free to remove these global APIs when the deprecation cycle is up (April 2026) and encourage people to use TORCH_BOX and avoid from/to entirely. Pull Request resolved: pytorch#164956 Approved by: https://github.com/malfet ghstack dependencies: pytorch#164882
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
Pull Request resolved: pytorch#164959 Approved by: https://github.com/Skylion007, https://github.com/mikaylagawarecki ghstack dependencies: pytorch#164882, pytorch#164956
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
ghstack-source-id: 3389bff Pull Request resolved: pytorch/pytorch#164956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To not pollute the global namespace, we should move the
from/toAPIs into torch::stable::detail. We are also following our normal deprecation cycle and choosing to continue exposing the globalfrom/tofor the time being as people who onboard their extensions onto 2.9 would not be able to build with 2.10 otherwise.Note that this means that within libtorch, we do not get the luxury of tacking on a
using torch::stable::detail::frombecause then it leads to build time ambiguous calls --> both the global and namespace APIs are exposed, which one do I want? So that is why you see every local site is updated.Note that the update is not necessary from a custom op writer point of view. FA3 can continue to build on torch nightlies without changing any code. (Since this is a header change, this PR has no implication on runtime, a previously built FA3 ABI stable wheel will continue to work fine with newer torch versions after this PR.)
Once TORCH_BOX lands, we would be free to remove these global APIs when the deprecation cycle is up (April 2026) and encourage people to use TORCH_BOX and avoid from/to entirely.
Stack from ghstack (oldest at bottom):