[Inductor][ATen] Fix stride rounding on Blockwise128x128 to accommodate for small shapes#164953
Closed
jananisriram wants to merge 1 commit intomainfrom
Closed
[Inductor][ATen] Fix stride rounding on Blockwise128x128 to accommodate for small shapes#164953jananisriram wants to merge 1 commit intomainfrom
jananisriram wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164953
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e52aa0d with merge base d2cb183 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@jananisriram has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84103213. |
jananisriram
added a commit
that referenced
this pull request
Oct 8, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Differential Revision: D84103213
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Differential Revision: D84103213
facebook-github-bot
force-pushed
the
export-D84103213
branch
from
72908c1 to
4c2464c
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Differential Revision: D84103213
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Differential Revision: D84103213
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Differential Revision: D84103213
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Differential Revision: D84103213
jananisriram
added a commit
that referenced
this pull request
Oct 9, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Differential Revision: D84103213
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Differential Revision: D84103213
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Reviewed By: slayton58 Differential Revision: D84103213
facebook-github-bot
force-pushed
the
export-D84103213
branch
from
4c2464c to
e52aa0d
Compare
jananisriram
added a commit
that referenced
this pull request
Oct 10, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Reviewed By: slayton58 Differential Revision: D84103213
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Reviewed By: slayton58 Differential Revision: D84103213
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Reviewed By: slayton58 Differential Revision: D84103213
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Reviewed By: slayton58 Differential Revision: D84103213
slayton58
approved these changes
Oct 10, 2025
Contributor
slayton58
left a comment
slayton58
left a comment
There was a problem hiding this comment.
LGTM, verified tests pass clean on H100.
eqy
approved these changes
Oct 10, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jananisriram
added a commit
that referenced
this pull request
Oct 10, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Reviewed By: slayton58 Differential Revision: D84103213
jananisriram
added a commit
that referenced
this pull request
Oct 10, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Reviewed By: slayton58 Differential Revision: D84103213
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
…te for small shapes (#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Reviewed By: slayton58 Differential Revision: D84103213
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…te for small shapes (pytorch#164953) Summary: Fix rounding issue on `Blockwise128x128` to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures for `test_fp8.py` tests as well as `test_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wise` tests ([GitHub PR](pytorch#164259)). Test Plan: `test_fp8.py` `test_scaled_matmul_cuda.py` Differential Revision: D84103213 Pull Request resolved: pytorch#164953 Approved by: https://github.com/slayton58, https://github.com/eqy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Fix rounding issue on
Blockwise128x128to accommodate for small shapes. The original implementation rounded all strides to 4, which caused failures fortest_fp8.pytests as well astest_scaled_matmul_cuda.py::test_scaled_mm_vs_emulated_block_wisetests (GitHub PR).Test Plan:
test_fp8.pytest_scaled_matmul_cuda.pyDifferential Revision: D84103213