Skip to content

[CMake] Remove forcing of -O2 from torch_compile_options#164894

Closed
malfet wants to merge 2 commits intogh/malfet/547/basefrom
gh/malfet/547/head
Closed

[CMake] Remove forcing of -O2 from torch_compile_options#164894
malfet wants to merge 2 commits intogh/malfet/547/basefrom
gh/malfet/547/head

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 7, 2025

Stack from ghstack (oldest at bottom):

That was introduced by 75a65ff
Hattip to @jathu for alerting me about the issue. As result, all our PyTorch builds were shipped with -O2 for almost all of its modern history

Partially undo the damage introduced by #128406 that cause cross-ISA symbols leak, to be properly followed up in #165123

cc @seemethere

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164894

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 73 Pending

As of commit 9f8a8b4 with merge base 600267e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Oct 7, 2025
That was introduced by 75a65ff

ghstack-source-id: 118ab21
Pull Request resolved: #164894
@malfet malfet requested review from albanD and ezyang October 7, 2025 23:23
@malfet malfet added ci-no-td Do not run TD on this PR module: build Build system issues topic: improvements topic category ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request release notes: build release notes category labels Oct 7, 2025
[ghstack-poisoned]
malfet added a commit that referenced this pull request Oct 10, 2025
That was introduced by 75a65ff

ghstack-source-id: 59b9fe7
Pull Request resolved: #164894
@malfet
Copy link
Contributor Author

malfet commented Oct 10, 2025

@pytorchbot merge -f "aarch64 builds are green this time around"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
…#164894)

That was introduced by pytorch@75a65ff
Hattip to @jathu for alerting me about the issue. As result, all our PyTorch builds were shipped with `-O2` for almost all of its modern history

Partially undo the damage introduced by pytorch#128406 that cause cross-ISA symbols leak, to be properly followed up in pytorch#165123

Pull Request resolved: pytorch#164894
Approved by: https://github.com/ezyang
@github-actions github-actions bot deleted the gh/malfet/547/head branch November 10, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: build Build system issues release notes: build release notes category topic: improvements topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants