Skip to content

[reland] Allow setting grad_dtype on leaf tensors#164751

Closed
soulitzer wants to merge 1 commit intomainfrom
soulitzer/reland-codev-grad-dtype
Closed

[reland] Allow setting grad_dtype on leaf tensors#164751
soulitzer wants to merge 1 commit intomainfrom
soulitzer/reland-codev-grad-dtype

Conversation

@soulitzer
Copy link
Contributor

@soulitzer soulitzer commented Oct 6, 2025

ghstack-source-id: e44b3941530be83a630ec93f1478eec741ffca2e
Pull-Request-resolved: #162815

Fixes #ISSUE_NUMBER

Relanding due to internal weirdness. Separate PR to codev w/o ghstack.

cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela @xmfan

@soulitzer soulitzer requested a review from albanD as a code owner October 6, 2025 17:33
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164751

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit aab2478 with merge base 2855a04 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 6, 2025
@soulitzer soulitzer added the release notes: autograd release notes category label Oct 6, 2025
@pytorch pytorch deleted a comment from github-actions bot Oct 6, 2025
@soulitzer soulitzer force-pushed the soulitzer/reland-codev-grad-dtype branch 2 times, most recently from b8cb16c to d8843ea Compare October 6, 2025 18:17
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@facebook-github-bot
Copy link
Contributor

@soulitzer has imported this pull request. If you are a Meta employee, you can view this in D83991140.

Summary:
ghstack-source-id: e44b394
Pull-Request-resolved: #162815

Fixes #ISSUE_NUMBER

Relanding due to internal weirdness. Separate PR to codev w/o ghstack.

cc EikanWang jgong5 wenzhe-nrv sanchitintel voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela xmfan


Reviewed By: janeyx99

Differential Revision: D83991140

Pulled By: soulitzer
@facebook-github-bot facebook-github-bot force-pushed the soulitzer/reland-codev-grad-dtype branch from d8843ea to aab2478 Compare October 7, 2025 18:28
@meta-codesync
Copy link

meta-codesync bot commented Oct 7, 2025

@soulitzer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83991140.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 8, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-jammy-py3.10-clang18-asan / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@izaitsevfb
Copy link
Contributor

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-jammy-py3.10-clang18-asan / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
ghstack-source-id: e44b394
Pull-Request-resolved: pytorch#162815

Fixes #ISSUE_NUMBER

Relanding due to internal weirdness. Separate PR to codev w/o ghstack.

Pull Request resolved: pytorch#164751
Approved by: https://github.com/albanD
@github-actions github-actions bot deleted the soulitzer/reland-codev-grad-dtype branch November 8, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged meta-exported module: compiled autograd compiled_autograd module: dynamo module: inductor oncall: jit Add this issue/PR to JIT oncall triage queue release notes: autograd release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants