[DeviceMesh] Remove private _set_mesh_dim_group_options API#164750
Closed
fduwjj wants to merge 3 commits intogh/fduwjj/219/basefrom
Closed
[DeviceMesh] Remove private _set_mesh_dim_group_options API#164750fduwjj wants to merge 3 commits intogh/fduwjj/219/basefrom
fduwjj wants to merge 3 commits intogh/fduwjj/219/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164750
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 58cbd49 with merge base 322091d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
oncall: distributed
fduwjj
changed the title
lw
reviewed
Oct 7, 2025
We allow passing in PG option via #159371 and we did a clean up of Meta internal usage of `_set_mesh_dim_group_options`, since this a private API, we don't have any bc guarantee, we want to directly remove so that people use the new behavior from now on. Also since we now allow passing pg in both DeviceMesh constructor and flatten API, so that we also want to get rid of the global pg option override variable. cc H-Huang awgu wanchaol fegin wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
We allow passing in PG option via #159371 and we did a clean up of Meta internal usage of `_set_mesh_dim_group_options`, since this a private API, we don't have any bc guarantee, we want to directly remove so that people use the new behavior from now on. Also since we now allow passing pg in both DeviceMesh constructor and flatten API, so that we also want to get rid of the global pg option override variable. cc H-Huang awgu wanchaol fegin wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
fegin
approved these changes
Oct 8, 2025
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 8, 2025
…cess API (#164954) This is mostly mechanical change which make device mesh members all private and use a public property API instead. This is not a BC breaking change since the new API still guarantee BC. Pull Request resolved: #164954 Approved by: https://github.com/fegin ghstack dependencies: #164750
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 9, 2025
…nd types for _get_slice_mesh_layout (#164993) As title, we want to add a deprecate warning for slicing flattened dim from root mesh. Also cosmetic changes for adding types for `_get_slice_mesh_layout`. Pull Request resolved: #164993 Approved by: https://github.com/fegin ghstack dependencies: #164750, #164954
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…164750) We allow passing in PG option via pytorch#159371 and we did a clean up of Meta internal usage of `_set_mesh_dim_group_options`, since this a private API, we don't have any bc guarantee, we want to directly remove so that people use the new behavior from now on. Also since we now allow passing pg in both DeviceMesh constructor and flatten API, so that we also want to get rid of the global pg option override variable. Pull Request resolved: pytorch#164750 Approved by: https://github.com/lw, https://github.com/fegin
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…cess API (pytorch#164954) This is mostly mechanical change which make device mesh members all private and use a public property API instead. This is not a BC breaking change since the new API still guarantee BC. Pull Request resolved: pytorch#164954 Approved by: https://github.com/fegin ghstack dependencies: pytorch#164750
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…nd types for _get_slice_mesh_layout (pytorch#164993) As title, we want to add a deprecate warning for slicing flattened dim from root mesh. Also cosmetic changes for adding types for `_get_slice_mesh_layout`. Pull Request resolved: pytorch#164993 Approved by: https://github.com/fegin ghstack dependencies: pytorch#164750, pytorch#164954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We allow passing in PG option via #159371 and we did a clean up of Meta internal usage of
_set_mesh_dim_group_options, since this a private API, we don't have any bc guarantee, we want to directly remove so that people use the new behavior from now on.Also since we now allow passing pg in both DeviceMesh constructor and flatten API, so that we also want to get rid of the global pg option override variable.
cc @H-Huang @awgu @wanchaol @fegin @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci