remove size-like based size-oblivious special max simplifications#164665
Closed
laithsakka wants to merge 4 commits intogh/laithsakka/295/basefrom
Closed
remove size-like based size-oblivious special max simplifications#164665laithsakka wants to merge 4 commits intogh/laithsakka/295/basefrom
laithsakka wants to merge 4 commits intogh/laithsakka/295/basefrom
Conversation
[ghstack-poisoned]
This was referenced Oct 4, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164665
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 794d78b with merge base 1fc71d1 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: dynamo
release notes: fx
laithsakka
changed the title
…cations" As we removed guard_size_oblivious this simplification is no longer relevant, this is part of the process of deprecation for guard_size_oblivious and its dependencies. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…cations" As we removed guard_size_oblivious this simplification is no longer relevant, this is part of the process of deprecation for guard_size_oblivious and its dependencies. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
This was referenced Oct 5, 2025
Closed
…cations" As we removed guard_size_oblivious this simplification is no longer relevant, this is part of the process of deprecation for guard_size_oblivious and its dependencies. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
This was referenced Oct 7, 2025
aorenste
approved these changes
Oct 7, 2025
Collaborator
|
Starting merge as part of PR stack under #164667 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 7, 2025
Pull Request resolved: #164667 Approved by: https://github.com/angelayi ghstack dependencies: #164664, #164665
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 8, 2025
Pull Request resolved: #164668 Approved by: https://github.com/angelayi ghstack dependencies: #164664, #164665, #164667
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 8, 2025
Pull Request resolved: #164753 Approved by: https://github.com/aorenste, https://github.com/mlazos ghstack dependencies: #164664, #164665, #164667, #164668
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…torch#164665) As we removed guard_size_oblivious this simplification is no longer relevant, this is part of the process of deprecation for guard_size_oblivious and its dependencies. Pull Request resolved: pytorch#164665 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#164664
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
Pull Request resolved: pytorch#164667 Approved by: https://github.com/angelayi ghstack dependencies: pytorch#164664, pytorch#164665
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
Pull Request resolved: pytorch#164668 Approved by: https://github.com/angelayi ghstack dependencies: pytorch#164664, pytorch#164665, pytorch#164667
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
Pull Request resolved: pytorch#164753 Approved by: https://github.com/aorenste, https://github.com/mlazos ghstack dependencies: pytorch#164664, pytorch#164665, pytorch#164667, pytorch#164668
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As we removed guard_size_oblivious this simplification is no longer relevant, this is part of the process of
deprecation for guard_size_oblivious and its dependencies.
cc @ezyang @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela