Limit path search within range #164581
Closed
Limit path search within range #164581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164581
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit b5ae6f6 with merge base 7617b11 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
reviewed
Oct 3, 2025
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
When we are looking if two nodes are dependent, limit bath search within the bounds of their node idxs. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
Contributor
|
Untestable? |
Contributor
Author
|
All of the existing tests of bucketing, etc, should exercise this. But i can add a small one. |
ezyang
approved these changes
Oct 6, 2025
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
High level approach seems fine, I didn't do a fine grained code review
When we are looking if two nodes are dependent, limit path search within the bounds of their node idxs. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 7, 2025
Original work by @ShatianWang, with lints applied. I am going to a few changes and add tests in subsequent prs but I want to preserve original commit first. Pull Request resolved: #164738 Approved by: https://github.com/IvanKobzarev ghstack dependencies: #164568, #164569, #164581
Contributor
Author
|
@pytorchbot revert -m "merge sets makes this trickier" |
|
❌ 🤖 pytorchbot command failed: Try |
Contributor
Author
|
@pytorchbot revert -m "merge sets makes this trickier" -c "weird" |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Oct 8, 2025
This reverts commit ab01a0d. Reverted #164738 on behalf of https://github.com/eellison due to merge sets makes this trickier ([comment](#164581 (comment)))
pytorchmergebot
added a commit
that referenced
this pull request
Oct 8, 2025
This reverts commit 415e641. Reverted #164581 on behalf of https://github.com/eellison due to merge sets makes this trickier ([comment](#164581 (comment)))
Collaborator
|
@eellison your PR has been successfully reverted. |
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
When we are looking if two nodes are dependent, limit path search within the bounds of their node idxs. Pull Request resolved: pytorch#164581 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#164568, pytorch#164569
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
Original work by @ShatianWang, with lints applied. I am going to a few changes and add tests in subsequent prs but I want to preserve original commit first. Pull Request resolved: pytorch#164738 Approved by: https://github.com/IvanKobzarev ghstack dependencies: pytorch#164568, pytorch#164569, pytorch#164581
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
This reverts commit ab01a0d. Reverted pytorch#164738 on behalf of https://github.com/eellison due to merge sets makes this trickier ([comment](pytorch#164581 (comment)))
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
This reverts commit 415e641. Reverted pytorch#164581 on behalf of https://github.com/eellison due to merge sets makes this trickier ([comment](pytorch#164581 (comment)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
When we are looking if two nodes are dependent, limit path search within the bounds of their node idxs.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben