Skip to content

Conversation

@eellison
Copy link
Contributor

@eellison eellison commented Oct 3, 2025

@pytorch-bot pytorch-bot bot added ciflow/inductor module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Oct 3, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164569

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3ee7d6c with merge base 7617b11 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison added a commit that referenced this pull request Oct 3, 2025
ghstack-source-id: 09311bf
Pull Request resolved: #164569
cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
eellison added a commit that referenced this pull request Oct 3, 2025
ghstack-source-id: fa58952
Pull Request resolved: #164569
cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
eellison added a commit that referenced this pull request Oct 3, 2025
ghstack-source-id: ab9bd8b
Pull Request resolved: #164569
@eellison eellison added the topic: not user facing topic category label Oct 3, 2025
Now that we have a hop to add implicit deps - use those deps for comm/compute overlap.

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
eellison added a commit that referenced this pull request Oct 3, 2025
ghstack-source-id: 8d285f8
Pull Request resolved: #164569
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems plausible

Now that we have a hop to add implicit deps - use those deps for comm/compute overlap.

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
eellison added a commit that referenced this pull request Oct 3, 2025
ghstack-source-id: c04fc71
Pull Request resolved: #164569
Now that we have a hop to add implicit deps - use those deps for comm/compute overlap.

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
@eellison
Copy link
Contributor Author

eellison commented Oct 6, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 6, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Oct 6, 2025
When we are looking if two nodes are dependent, limit path search within the bounds of their node idxs.

Pull Request resolved: #164581
Approved by: https://github.com/ezyang
ghstack dependencies: #164568, #164569
pytorchmergebot pushed a commit that referenced this pull request Oct 7, 2025
Original work by @ShatianWang, with lints applied. I am going to a few changes and add tests in subsequent prs but I want to preserve original commit first.

Pull Request resolved: #164738
Approved by: https://github.com/IvanKobzarev
ghstack dependencies: #164568, #164569, #164581
eellison added a commit to eellison/pytorch that referenced this pull request Oct 11, 2025
ghstack-source-id: b561e11
Pull Request resolved: pytorch#164569
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
Now that we have a hop to add implicit deps - use those deps for comm/compute overlap.

Pull Request resolved: pytorch#164569
Approved by: https://github.com/ezyang, https://github.com/IvanKobzarev
ghstack dependencies: pytorch#164568
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
When we are looking if two nodes are dependent, limit path search within the bounds of their node idxs.

Pull Request resolved: pytorch#164581
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#164568, pytorch#164569
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
Original work by @ShatianWang, with lints applied. I am going to a few changes and add tests in subsequent prs but I want to preserve original commit first.

Pull Request resolved: pytorch#164738
Approved by: https://github.com/IvanKobzarev
ghstack dependencies: pytorch#164568, pytorch#164569, pytorch#164581
@github-actions github-actions bot deleted the gh/eellison/837/head branch November 6, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants